Skip to content

Commit

Permalink
chore(ngen): update note to self on multi-model calibration mechanics
Browse files Browse the repository at this point in the history
  • Loading branch information
hellkite500 authored and aaraney committed Sep 20, 2024
1 parent 9a268a9 commit bb31102
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion python/ngen_cal/src/ngen/cal/ngen.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@ def _params_as_df(params: Mapping[str, Parameters], name: str = None):
return df

def _map_params_to_realization(params: Mapping[str, Parameters], realization: Realization):
# don't even think about calibration multiple formulations at once just yet..
# Since params are mapped by model name, we can track the model/param relationship
# in the dataframe to reconstruct each models parameters indepndently
# with a unique parameter index build in _params_as_df, this supports multi-model
# parameters with a key distinction --
# WARNING parameters with the _exact_ same name between two models will be exposed
# as two parameters in the parameter space, but will always share the same value
module = realization.formulations[0].params

if isinstance(module, MultiBMI):
Expand Down

0 comments on commit bb31102

Please sign in to comment.