Remove the redundant valid_time parameter from WRDS NWM requests, #292.

NOAA-OWP · Sep 3, 2024 · 296021e · 296021e
1 parent 1502384
commit 296021e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/wres-reading/src/wres/reading/wrds/nwm/WrdsNwmReader.java b/wres-reading/src/wres/reading/wrds/nwm/WrdsNwmReader.java
@@ -664,7 +664,6 @@ private Map<String, String> createWrdsNwmUrlParameters( Pair<Instant, Instant> r
                            + ","
                            + wrdsFormattedDates.getRight()
                            + "]" );
-        urlParameters.put( "valid_time", "all" );
 
         return Collections.unmodifiableMap( urlParameters );
     }

diff --git a/wres-reading/test/wres/reading/wrds/nwm/WrdsNwmReaderTest.java b/wres-reading/test/wres/reading/wrds/nwm/WrdsNwmReaderTest.java
@@ -384,20 +384,17 @@ void testReadReturnsThreeChunkedForecastTimeSeries()
         Parameters parametersOne = new Parameters( new Parameter( "proj", "UNKNOWN_PROJECT_USING_WRES" ),
                                                    new Parameter( "reference_time",
                                                                   "(20220102T00Z,20220109T00Z]" ),
-                                                   new Parameter( "forecast_type", "deterministic" ),
-                                                   new Parameter( "valid_time", "all" ) );
+                                                   new Parameter( "forecast_type", "deterministic" ) );
 
         Parameters parametersTwo = new Parameters( new Parameter( "proj", "UNKNOWN_PROJECT_USING_WRES" ),
                                                    new Parameter( "reference_time",
                                                                   "(20220109T00Z,20220116T00Z]" ),
-                                                   new Parameter( "forecast_type", "deterministic" ),
-                                                   new Parameter( "valid_time", "all" ) );
+                                                   new Parameter( "forecast_type", "deterministic" ) );
 
         Parameters parametersThree = new Parameters( new Parameter( "proj", "UNKNOWN_PROJECT_USING_WRES" ),
                                                      new Parameter( "reference_time",
                                                                     "(20220116T00Z,20220123T00Z]" ),
-                                                     new Parameter( "forecast_type", "deterministic" ),
-                                                     new Parameter( "valid_time", "all" ) );
+                                                     new Parameter( "forecast_type", "deterministic" ) );
 
         this.mockServer.when( HttpRequest.request()
                                          .withPath( FORECAST_PATH )
@@ -635,8 +632,7 @@ void testReadRequestsDateRangeWithMinutesAndSeconds()
 
         WrdsNwmReader reader = WrdsNwmReader.of( declaration, systemSettings );
 
-        Parameters parametersOne = new Parameters( new Parameter( "valid_time", "all" ),
-                                                   new Parameter( "proj", "UNKNOWN_PROJECT_USING_WRES" ),
+        Parameters parametersOne = new Parameters( new Parameter( "proj", "UNKNOWN_PROJECT_USING_WRES" ),
                                                    new Parameter( "reference_time",
                                                                   "(20240901T000000Z,20240903T002759Z]" ),
                                                    new Parameter( "forecast_type", "deterministic" ) );
-Original file line number
+Diff line change
@@ Expand Up @@
                                + ","
                                + wrdsFormattedDates.getRight()
                                + "]" );
-            urlParameters.put( "valid_time", "all" );
             return Collections.unmodifiableMap( urlParameters );
         }
@@ Expand Down @@