Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue130 #379

Merged
merged 24 commits into from
Jan 16, 2025
Merged

Issue130 #379

merged 24 commits into from
Jan 16, 2025

Conversation

james-d-brown
Copy link
Collaborator

Description

Fixes #130.

Changes Made

Testing

Related Tickets

Checklists

Deployment Plan (For developer use)

How does the changes affect the product?

  • Feature addition
  • Bug fix
  • Database change

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • The feature branch you're submitting as a PR is up to date
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • No Placeholder code
  • Reviewers requested
  • Add yourself as an assignee in the PR

Merge Checklist (For Technical Lead use only)

  • If applicable, update README with major alterations

@james-d-brown
Support the declaration of event detection, #130
b648481
@james-d-brown
Validate the declaration of event detection and wire in to a placehol…
6e3fcdc 
…der method that returns the universal time window, #130
@james-d-brown
Continue to wire in event detection using a placeholder for the final…
38a8a21 
… detection request, #130
@james-d-brown
Add a new module for event detection, #130
891faf8
@james-d-brown
Add an event detection method based on Regina and Ogden (2021), #130
677f22c
@james-d-brown
Adjust the calculation of the average time-step to use the mode rathe…
cde94d4 
…r than the mean when performing event detection. Handle the situation where the last value is missing during smoothing, #130
@james-d-brown
Generate graphics with valid date pools when event detection is decla…
7d4394a 
…red, #130
@james-d-brown
Fully qualify the time windows associated with the legacy CSV file na…
38c78e4 
…mes when generating outputs by valid date pool, #130
@james-d-brown
Add a unit test for event detection with default parameters, #130
b5c19aa
@james-d-brown
Refactor the utilities for time windows and add unit tests, #130
cd5f16b
@james-d-brown
Fix a bug in the ordering of time windows, #130
9a5c00f
@james-d-brown
Add unit tests for the intersection of time windows, #130
e0bf850
@james-d-brown
Support the declaration of a union or intersection of detected events, …
da752f3 
…#130
@james-d-brown
Add several junit integration tests for the EventsGenerator, #130.
ab5c212
@james-d-brown
Allow for the aggregation of intersected events, #130.
badf3bc
@james-d-brown
Improve logging, #130.
78a470e
@james-d-brown
Add a unit test for time window intersection, #130.
12c1edd
@james-d-brown
Add another unit test for time window intersection, #130.
d916ebf
@james-d-brown
Support timing error statistics for non-forecast datasets, #130, #376.
89b99ce
@james-d-brown
Fix the domain axis title in plots of timing error durations for non-…
20e5688 
…forecast time-series, #130.
@james-d-brown
Fix the qualification of time windows in the title of plots generated…
65da5a8 
… from event-shaped pools, #130.
@james-d-brown
Fix the legend title of plots generated with pooling windows, #130.
236a250
@james-d-brown
Interpolate the purpose of covariates for event detection, #130.
794546d
@james-d-brown
Merge branch 'refs/heads/master' into issue130
39f4499
@james-d-brown james-d-brown added the enhancement New feature or improvement label Jan 16, 2025
@james-d-brown james-d-brown added this to the v6.29 milestone Jan 16, 2025
@james-d-brown james-d-brown self-assigned this Jan 16, 2025
@james-d-brown james-d-brown merged commit 1e3ba64 into master Jan 16, 2025
6 checks passed
@james-d-brown james-d-brown deleted the issue130 branch January 16, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@james-d-brown james-d-brown

Labels
enhancement New feature or improvement
Projects
None yet
Milestone
v6.29
Development

Successfully merging this pull request may close these issues.

As a developer, I want to identify and implement a solution for event-based evaluations
1 participant
@james-d-brown