Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podp: not all genome IDs are in antismashDB #242

Closed
liannette opened this issue May 7, 2024 · 1 comment · Fixed by #262
Closed

Podp: not all genome IDs are in antismashDB #242

liannette opened this issue May 7, 2024 · 1 comment · Fixed by #262
Assignees

Comments

@liannette
Copy link

In podp mode, the genome RefSeq IDs are used to download the antismash results from antismashDB.
However, not all RefSeq genomes are in antismashDB, leading to an incomplete dataset.

Suggestion:
Check whether all genomes could be downloaded from antismashDB, and if not, output a message that the missing antimash results need to be manually added before continuing the script.

@github-project-automation github-project-automation bot moved this to Backlog in dev May 7, 2024
@CunliangGeng CunliangGeng self-assigned this Jun 4, 2024
@CunliangGeng
Copy link
Member

Will add a log message (Warning) to report the missing antismash results

@CunliangGeng CunliangGeng moved this from Backlog to In progress in dev Jul 3, 2024
@CunliangGeng CunliangGeng linked a pull request Jul 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in dev Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants