Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning for failed antismash downloads #262

Merged
merged 6 commits into from
Jul 6, 2024
Merged

add warning for failed antismash downloads #262

merged 6 commits into from
Jul 6, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jul 3, 2024 •
edited
Loading

To solve issue #242.

@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jul 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng mentioned this pull request Jul 3, 2024
Merged
@CunliangGeng CunliangGeng requested a review from gcroci2 July 3, 2024 10:45
@CunliangGeng CunliangGeng self-assigned this Jul 3, 2024
@CunliangGeng CunliangGeng linked an issue Jul 3, 2024 that may be closed by this pull request
Podp: not all genome IDs are in antismashDB #242
Closed
@CunliangGeng CunliangGeng marked this pull request as ready for review July 3, 2024 10:45
@CunliangGeng CunliangGeng mentioned this pull request Jul 4, 2024
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Jul 6, 2024 •
edited
Loading

Merge activity

  • Jul 6, 5:45 AM EDT: @CunliangGeng started a stack merge that includes this pull request via Graphite.
  • Jul 6, 5:47 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 6, 5:48 AM EDT: @CunliangGeng merged this pull request with Graphite.

Base automatically changed from check_disk_space to dev July 6, 2024 09:45
@CunliangGeng CunliangGeng force-pushed the warn_failed_antismash_downloads branch from dffcbe3 to 8080748 Compare July 6, 2024 09:46
@CunliangGeng CunliangGeng merged commit 1d5f50c into dev Jul 6, 2024
2 of 3 checks passed
@CunliangGeng CunliangGeng deleted the warn_failed_antismash_downloads branch July 6, 2024 09:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podp: not all genome IDs are in antismashDB
2 participants
@CunliangGeng @gcroci2