Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unavailable GNPS service #159

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Handle unavailable GNPS service #159

merged 4 commits into from
Jul 11, 2023

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jul 11, 2023 •
edited
Loading

GPNS service is down in 11 July 2023 (see below). This leads to failed unit tests of downloading GNPS data.
image

To handle the down service:

  • Add time out (5s) to the http request to GNPS to avoid hanging infinitely. When time is out, an ReadTimeout error is raised.
  • Also removed the deprecated functions for downloading GNPS data. These functions have been replaced by GNPSDownloader.

@gcroci2 gcroci2 mentioned this pull request Jul 11, 2023
Merged
gcroci2
gcroci2 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I was very confused by the new errors indeed

@CunliangGeng CunliangGeng merged commit aad7a52 into dev Jul 11, 2023
2 of 4 checks passed
@CunliangGeng CunliangGeng deleted the add_readtimeout_for_down_gnps branch July 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2