change class method to static method

[CunliangGeng]

The discussion during standup triggered me to reflect on the usage of @classmethod. Only one place in the codebase used @classmethod, which is actually not suitable . So I change it to static method.

👉 When to use @classmethod?
Use @classmethod when the method needs to affect or make use of class-level data (like the count below)

class MyClass:
    count = 0

    def __init__(self):
        MyClass.count += 1

    @classmethod
    def get_count(cls):
        return cls.count

[gcroci2]

Seems more logic this way! I still struggle a bit in understanding clearly when a class method is better than a static one and viceversa.

[CunliangGeng]

Seems more logic this way! I still struggle a bit in understanding clearly when a class method is better than a static one and viceversa.

@classmethod is an advanced feature, which means it's not used in 99.999% situations. Here are some materials to understand it

• https://realpython.com/instance-class-and-static-methods-demystified/
• https://stackoverflow.com/questions/5738470/whats-an-example-use-case-for-a-python-classmethod