use list for returned type of get_bgcs methods of BGC loaders
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change returned value from dict to list for `MibigLoader.get_bgcs` method and the underlying method `._parse_bgcs` - update the use of the changed methods - update unit tests
- change returned value from dict to list for `AntismashBGCLoader.get_bgcs` method and the underlying method `._parse_bgcs` - update the use of the changed methods - update unit tests
|
This PR will be closed and a new but same PR (#182) is created by Graphite, please review the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed the returned value of
get_bgcsmethods in BGC loaders from dict to list, making sure that methodsget_bgcsandget_gcfshave consistent returned type.