-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated functions of loading genomics data #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2023
This was referenced Nov 20, 2023
Merged
This was referenced Nov 27, 2023
Merged
gcroci2
approved these changes
Dec 11, 2023
CunliangGeng
force-pushed
the
11-20-change_Strain_filename
branch
from
December 11, 2023 13:03
dc2efbe
to
4ab7c15
Compare
CunliangGeng
force-pushed
the
11-20-remove_deprecated_genomics_functions
branch
from
December 11, 2023 13:03
3d8330a
to
58ccf13
Compare
This was referenced Dec 11, 2023
CunliangGeng
force-pushed
the
11-20-change_Strain_filename
branch
from
December 14, 2023 10:39
4ab7c15
to
de37733
Compare
CunliangGeng
force-pushed
the
11-20-remove_deprecated_genomics_functions
branch
from
December 14, 2023 10:39
58ccf13
to
b633448
Compare
CunliangGeng
force-pushed
the
11-20-change_Strain_filename
branch
from
December 14, 2023 10:48
de37733
to
b645894
Compare
CunliangGeng
force-pushed
the
11-20-remove_deprecated_genomics_functions
branch
from
December 14, 2023 10:50
b633448
to
93f2404
Compare
Merge activity
|
This function is needed anymore. GCF loader already has the functionality to filter mibig only GCF during loading.
CunliangGeng
force-pushed
the
11-20-remove_deprecated_genomics_functions
branch
from
December 14, 2023 10:53
93f2404
to
87edc7e
Compare
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated function
load_gcfs
andfilter_mibig_only_gcf
.