Refactor config loader #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove class `Args` and `Config` - Remove unused dependencies
This is a temporary change. The config file template will be reviewed and updated later.
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
To include the default config file when building nplinker package
gcroci2
approved these changes
Feb 7, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed the way to load config file (
nplinker.toml) by replacing the legacy code with the package of configuration management Dynaconf.By using Dynaconf, the loaded config (which is a variable) is importable and thus can be accessed across different functions/classes/modules without passing it as a parameter (Detail see example Using Python Only).
Major changes:
ArgsandConfig) and related dependenciesnplinker_default.tomlwith a part of nplinker settings (not complete yet)Note:
The template of config file
nplinker.tomlneeds to be updated in the following PRs. So in this PR I didn't set default values for all current configurations that will be changed later, nor did I update all their use in the codebase.