Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies #226

Merged
merged 4 commits into from
Mar 21, 2024
Merged

update dependencies #226

merged 4 commits into from
Mar 21, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Mar 18, 2024 •
edited
Loading

Major changes

  • remove unused dependencies and add required ones
  • fix typing error in python v3.9 by adding from __future__ import annotations
  • fix bug on checking gnps website status

@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Mar 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng mentioned this pull request Mar 18, 2024
Merged
@CunliangGeng CunliangGeng self-assigned this Mar 18, 2024
@CunliangGeng CunliangGeng mentioned this pull request Mar 18, 2024
Merged
gcroci2
gcroci2 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only a couple of questions but I already approve it :)

requirements.dev.txt Show resolved Hide resolved
src/nplinker/metabolomics/gnps/gnps_downloader.py Show resolved Hide resolved
This was referenced Mar 21, 2024
Merged
Closed
Base automatically changed from fix_actions_lfs to dev March 21, 2024 11:59
@CunliangGeng
remove unused dependencies and add required ones
24b7518
@CunliangGeng
only use Self when checking static typing
6916378
@CunliangGeng
fix typing error in python v3.9
9de4fc2 
python v3.9 does not support "|", and `from __future__ import annotations` can solve this problem.
@CunliangGeng
fix bug on checking gnps website status
dee0a4c 
add `follow_redirects` to get the actual status of gnps website
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Mar 21, 2024 •
edited
Loading

Merge activity

@CunliangGeng CunliangGeng merged commit a892925 into dev Mar 21, 2024
5 of 7 checks passed
@CunliangGeng CunliangGeng deleted the update_deps branch March 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

@CunliangGeng CunliangGeng

Labels
None yet
Projects
dev
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CunliangGeng @gcroci2