Skip to content

Commit

Permalink
Attempted fix for #320
Browse files Browse the repository at this point in the history
AdvancedMH or one of its dependencies may have updated a keyword from "initial_config" to "initial_params".
This caused NQCD to not deliver initial positions to the sampling chain correctly.
  • Loading branch information
Alexsp32 committed Dec 11, 2023
1 parent 0d22b50 commit efef3db
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/InitialConditions/ThermalMonteCarlo.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ using NQCDynamics:
masses

"""
run_advancedhmc_sampling(sim, r, steps, σ; move_ratio=0.0, internal_ratio=0.0)
run_advancedmh_sampling(sim, r, steps, σ; move_ratio=0.0, internal_ratio=0.0)
Sample the configuration space for the simulation `sim` starting from `r`.
Expand All @@ -47,7 +47,8 @@ function run_advancedmh_sampling(
steps::Real,
σ::Dict{Symbol,<:Real};
move_ratio=0.0,
internal_ratio=0.0
internal_ratio=0.0,
kwargs...
)

density = get_density_function(sim)
Expand All @@ -60,7 +61,7 @@ function run_advancedmh_sampling(
initial_config = reshape_input(sim, copy(r))

chain = AdvancedMH.sample(density_model, sampler, convert(Int, steps);
init_params=initial_config)
initial_params=initial_config, kwargs...)

return reshape_output(sim, chain)
end
Expand Down

0 comments on commit efef3db

Please sign in to comment.