Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: 0.13.4 #309

Merged
merged 3 commits into from
Nov 6, 2023
Merged

New version: 0.13.4 #309

merged 3 commits into from
Nov 6, 2023

Conversation

jamesgardner1421
Copy link
Member

Add new compat entries and fix broken test

fix #308 fix #306 fix #305 fix #304 fix #303 fix #302

@Alexsp32
Copy link
Member

Alexsp32 commented Nov 6, 2023

There seems to be a difference between machines for the allocations issue, since my M1 Mac now fails the problematic tests while Avon doesn't. Maybe we should pass for both values.

@jamesgardner1421
Copy link
Member Author

There seems to be a difference between machines for the allocations issue, since my M1 Mac now fails the problematic tests while Avon doesn't. Maybe we should pass for both values.

Probably MKL doesn't work on M1, I'll change it. Also trying to fix the broken mdef test

@Alexsp32
Copy link
Member

Alexsp32 commented Nov 6, 2023

M1 fix works for me.

Copy link
Member

@Alexsp32 Alexsp32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixes #308 on two separate machines
Confirmed tests all pass on two machines

@jamesgardner1421
Copy link
Member Author

I'm going to leave the documenter update for now because the build crashes locally for me. Can try that again another time

@jamesgardner1421 jamesgardner1421 merged commit bd02d86 into main Nov 6, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails on precompile due to SimpleNonlinearSolve.jl
2 participants