Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI tests #324

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix failing CI tests #324

merged 2 commits into from
Jan 3, 2024

Conversation

Alexsp32
Copy link
Member

MKL_jll v2024.0.0 fails to compile on several systems I've tried. Package dependencies should be set up to prevent installation, but resolving versions occasionally fails and installs this version anyway.

MKL_jll v2024.0.0 fails to compile on several systems I've tried.
Package dependencies should be set up to prevent installation,
but resolving versions occasionally seems to install this version anyway.
@Alexsp32 Alexsp32 self-assigned this Dec 11, 2023
@Alexsp32 Alexsp32 marked this pull request as ready for review December 11, 2023 10:05
@jamesgardner1421
Copy link
Member

If possible I would try to avoid using the separate Project.toml file in the test directory. Although the Julia docs makes it seem like this is the newer recommended method, it breaks all the time. Every other package I've seen on github still uses the old format with the [extras] field so I would suggest still doing that. You should be able to specify versions in the usual way in the [deps] section.
What is the problem with the new MKL? Is this a problem that everyone is having?

@Alexsp32 Alexsp32 marked this pull request as draft December 15, 2023 10:52
@Alexsp32
Copy link
Member Author

I've pinned MKL_jll.jl < 2024 within the main Project file now, which was thankfully possible with all existing dependencies.

I believe what's happening is that the main dependencies resolve MKL_jll@v2024 via LinearSolve.jl.
Requiring MKL.jl for tests should downgrade MKL_jll<v2024 as per compat entries for MKL.jl, but that doesn't appear to happen.

@Alexsp32 Alexsp32 marked this pull request as ready for review December 19, 2023 10:59
@Alexsp32 Alexsp32 merged commit 39a9603 into main Jan 3, 2024
11 of 13 checks passed
@Alexsp32 Alexsp32 deleted the ci-issue branch January 3, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants