-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ComponentSelector
feature: PSI portion
#1196
Conversation
947cbcd
to
bbaf11e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 77.23% 77.08% -0.16%
==========================================
Files 121 122 +1
Lines 13548 13561 +13
==========================================
- Hits 10464 10453 -11
- Misses 3084 3108 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Performance Results
|
Companion to and dependent on
ComponentSelector
feature: IS portion InfrastructureSystems.jl#342ComponentSelector
feature: PSY portion (take two) PowerSystems.jl#1197. The main thing here is we want
get_components
to work onIS.Results
such thatget_components
on aResults
is likeget_available_components
on its attachedSystem
(or attachedIS.SystemData
, etc.). The implementation of this behavior is in the IS PR, but following the design set out here, we need to definePSY.get_components
aliases that redirect to the appropriateIS.get_components
methods to keep the documentation user-friendly. That cannot be done in IS and (correct me if I'm wrong) it doesn't really make sense to do in PSY, so it is done here.