Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentSelector feature: PSI portion #1196

Merged
merged 5 commits into from
Jan 19, 2025
Merged

Conversation

GabrielKS
Copy link
Contributor

@GabrielKS GabrielKS commented Dec 12, 2024

Companion to and dependent on

. The main thing here is we want get_components to work on IS.Results such that get_components on a Results is like get_available_components on its attached System (or attached IS.SystemData, etc.). The implementation of this behavior is in the IS PR, but following the design set out here, we need to define PSY.get_components aliases that redirect to the appropriate IS.get_components methods to keep the documentation user-friendly. That cannot be done in IS and (correct me if I'm wrong) it doesn't really make sense to do in PSY, so it is done here.

@GabrielKS GabrielKS self-assigned this Dec 12, 2024
@GabrielKS GabrielKS force-pushed the gks/use_component_selector branch from 947cbcd to bbaf11e Compare January 17, 2025 20:19
Copy link
Contributor

@daniel-thom daniel-thom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (be194a3) to head (3d5b029).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/simulation/get_components_interface.jl 16.66% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   77.23%   77.08%   -0.16%     
==========================================
  Files         121      122       +1     
  Lines       13548    13561      +13     
==========================================
- Hits        10464    10453      -11     
- Misses       3084     3108      +24     
Flag Coverage Δ
unittests 77.08% <23.07%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/PowerSimulations.jl 100.00% <ø> (ø)
src/simulation/simulation_problem_results.jl 85.03% <100.00%> (+0.10%) ⬆️
src/simulation/get_components_interface.jl 16.66% <16.66%> (ø)

... and 4 files with indirect coverage changes

@jd-lara jd-lara merged commit aacc0c0 into main Jan 19, 2025
8 of 11 checks passed
@jd-lara jd-lara deleted the gks/use_component_selector branch January 19, 2025 22:39
Copy link
Contributor

Performance Results

Version Precompile Time
Main 4.143664251
This Branch 4.105875593
Version Build Time
Main-Build Time Precompile 67.274262322
Main-Build Time Postcompile 0.841611072
This Branch-Build Time Precompile 67.48648895
This Branch-Build Time Postcompile 1.142495406
Version Solve Time
Main-Solve Time Precompile 617.369816779
Main-Solve Time Postcompile 586.244575388
This Branch-Solve Time Precompile 409.805741304
This Branch-Solve Time Postcompile 370.452777463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants