Skip to content

Commit

Permalink
Space IV.5 - Implement sizing by space ext perimeter length doc
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Aug 30, 2024
1 parent 50eb559 commit 0e8b750
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions src/EnergyPlus/DataSizing.cc
Original file line number Diff line number Diff line change
Expand Up @@ -762,16 +762,12 @@ Real64 OARequirementsData::calcOAFlowRate(EnergyPlusData &state,
Real64 curNumOccupants = 0.0;
Real64 maxOccupants = 0.0;
if (spaceNum > 0) {
floorArea = state.dataHeatBal->space(spaceNum).FloorArea;
// TODO MJW: For now just proportion space volume by floor area
if (thisZone.FloorArea > 0.0) {
volume = thisZone.Volume * state.dataHeatBal->space(spaceNum).FloorArea / thisZone.FloorArea;
} else {
volume = 0.0;
}
nomTotOccupants = state.dataHeatBal->space(spaceNum).TotOccupants;
auto &thisSpace = state.dataHeatBal->space(spaceNum);
floorArea = thisSpace.FloorArea;
volume = thisSpace.Volume;
nomTotOccupants = thisSpace.TotOccupants;
curNumOccupants = state.dataHeatBal->spaceIntGain(spaceNum).NOFOCC;
maxOccupants = state.dataHeatBal->space(spaceNum).maxOccupants;
maxOccupants = thisSpace.maxOccupants;
} else {
floorArea = thisZone.FloorArea;
volume = thisZone.Volume;
Expand Down

4 comments on commit 0e8b750

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpacePart4Followup (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3707 of 3709 tests passed, 1 test warnings)

Messages:\n

  • 2 tests had: EIO diffs.
  • 1 test had: Table small diffs.
  • 1 test had: Table big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1586
  • Failed: 1

regression Test Summary

  • Passed: 812
  • Failed: 1

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpacePart4Followup (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2873 of 2874 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1584
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpacePart4Followup (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (797 of 797 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpacePart4Followup (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2079 of 2080 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1586
  • Failed: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.