Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/develop' into v23.2.0-IOFreeze-I…
Browse files Browse the repository at this point in the history
…DD_fixes
  • Loading branch information
Myoldmopar committed Sep 20, 2023
2 parents 67c4e7c + 3b44598 commit 1126f18
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/EnergyPlus/SolarShading.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7338,7 +7338,8 @@ void CalcInteriorSolarDistribution(EnergyPlusData &state)
} else {
TBmAll = TBmBm + TBmDif;
}
BTOTZone += TBmAll * SunLitFract * CosInc * state.dataSurface->Surface(SurfNum).Area * InOutProjSLFracMult; // [m2]
BTOTZone += state.dataSurface->Surface(SurfNum).IncSolMultiplier * TBmAll * SunLitFract * CosInc *
state.dataSurface->Surface(SurfNum).Area * InOutProjSLFracMult; // [m2]
}
}

Expand Down Expand Up @@ -7416,6 +7417,8 @@ void CalcInteriorSolarDistribution(EnergyPlusData &state)
TBm -= state.dataSurface->SurfWinBmSolAbsdInsReveal(SurfNum) / TBmDenom;
}
TBm = max(0.0, TBm);
// this multiplier doesn't work with other shading, so no need to apply in other branches
TBm *= state.dataSurface->Surface(SurfNum).IncSolMultiplier;
}

if (TBm == 0.0) continue;
Expand Down Expand Up @@ -8744,6 +8747,7 @@ void CalcInteriorSolarDistributionWCESimple(EnergyPlusData &state)
}

TBm = max(0.0, TBm);
TBm *= state.dataSurface->Surface(SurfNum).IncSolMultiplier;

int NumOfBackSurf = state.dataShadowComb->ShadowComb(BaseSurfNum).NumBackSurf;

Expand Down

5 comments on commit 1126f18

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v23.2.0-IOFreeze-IDD_fixes (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3566 of 3566 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v23.2.0-IOFreeze-IDD_fixes (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2739 of 2739 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v23.2.0-IOFreeze-IDD_fixes (Myoldmopar) - x86_64-MacOS-10.17-clang-14.0.0: OK (3525 of 3525 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v23.2.0-IOFreeze-IDD_fixes (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1953 of 1953 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v23.2.0-IOFreeze-IDD_fixes (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (789 of 789 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.