Skip to content

Commit

Permalink
refine surfQRadFromHVAC
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Dec 7, 2023
1 parent 37275cb commit 1d98cf0
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 18 deletions.
3 changes: 1 addition & 2 deletions src/EnergyPlus/ChilledCeilingPanelSimple.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1590,8 +1590,7 @@ void DistributeCoolingPanelRadGains(EnergyPlusData &state)

// Initialize arrays
for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.CoolingPanel = 0.0;
state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum).CoolingPanel = 0.0;
}
state.dataHeatBalFanSys->ZoneQCoolingPanelToPerson = 0.0;

Expand Down
3 changes: 1 addition & 2 deletions src/EnergyPlus/ElectricBaseboardRadiator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -907,8 +907,7 @@ namespace ElectricBaseboardRadiator {

// Initialize arrays
for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.ElecBaseboard = 0.0;
state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum).ElecBaseboard = 0.0;
}
state.dataHeatBalFanSys->ZoneQElecBaseboardToPerson = 0.0;

Expand Down
3 changes: 1 addition & 2 deletions src/EnergyPlus/HWBaseboardRadiator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1497,8 +1497,7 @@ namespace HWBaseboardRadiator {

// Initialize arrays
for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.HWBaseboard = 0.0;
state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum).HWBaseboard = 0.0;
}
state.dataHeatBalFanSys->ZoneQHWBaseboardToPerson = 0.0;

Expand Down
17 changes: 9 additions & 8 deletions src/EnergyPlus/HeatBalanceSurfaceManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -549,19 +549,20 @@ void InitSurfaceHeatBalance(EnergyPlusData &state)
state.dataHeatBalFanSys->QPVSysSource(SurfNum) = 0.0;
state.dataHeatBalFanSys->QPoolSurfNumerator(SurfNum) = 0.0;
state.dataHeatBalFanSys->PoolHeatTransCoefs(SurfNum) = 0.0;
for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.HTRadSys = 0.0;
thisSurfQRadFromHVAC.HWBaseboard = 0.0;
thisSurfQRadFromHVAC.SteamBaseboard = 0.0;
thisSurfQRadFromHVAC.ElecBaseboard = 0.0;
thisSurfQRadFromHVAC.CoolingPanel = 0.0;
}

} // ...end of Zone Surf loop
}
} // ...end of Zone loop

for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.HTRadSys = 0.0;
thisSurfQRadFromHVAC.HWBaseboard = 0.0;
thisSurfQRadFromHVAC.SteamBaseboard = 0.0;
thisSurfQRadFromHVAC.ElecBaseboard = 0.0;
thisSurfQRadFromHVAC.CoolingPanel = 0.0;
}

if (state.dataGlobal->ZoneSizingCalc) GatherComponentLoadsSurfAbsFact(state);

if (state.dataHeatBalSurfMgr->InitSurfaceHeatBalancefirstTime) {
Expand Down
3 changes: 1 addition & 2 deletions src/EnergyPlus/HighTempRadiantSystem.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1141,8 +1141,7 @@ namespace HighTempRadiantSystem {
dataHBFS->SumConvHTRadSys = 0.0;
dataHBFS->SumLatentHTRadSys = 0.0;
for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.HTRadSys = 0.0;
state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum).HTRadSys = 0.0;
}
dataHBFS->ZoneQHTRadSysToPerson = 0.0;

Expand Down
3 changes: 1 addition & 2 deletions src/EnergyPlus/SteamBaseboardRadiator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1523,8 +1523,7 @@ namespace SteamBaseboardRadiator {
Real64 ThisSurfIntensity; // temporary for W/m2 term for rad on a surface

for (int surfNum : state.dataSurface->allGetsRadiantHeatSurfaceList) {
auto &thisSurfQRadFromHVAC = state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum);
thisSurfQRadFromHVAC.SteamBaseboard = 0.0;
state.dataHeatBalFanSys->surfQRadFromHVAC(surfNum).SteamBaseboard = 0.0;
}
state.dataHeatBalFanSys->ZoneQSteamBaseboardToPerson = 0.0;

Expand Down

5 comments on commit 1d98cf0

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SysRadHeatGain10304 (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2759 of 2759 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SysRadHeatGain10304 (mjwitte) - x86_64-MacOS-10.17-clang-14.0.0: OK (3546 of 3546 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SysRadHeatGain10304 (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3587 of 3587 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SysRadHeatGain10304 (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1972 of 1972 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SysRadHeatGain10304 (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (790 of 790 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.