Skip to content

Commit

Permalink
log to log1p to see what diffs look like
Browse files Browse the repository at this point in the history
  • Loading branch information
@rraustad
rraustad committed Aug 23, 2024
1 parent a99cc59 commit 4b4da6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/EnergyPlus/ConvectionCoefficients.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6299,7 +6299,7 @@ Real64 CalcClearRoof(EnergyPlusData &state,

Real64 Rf = RoughnessMultiplier[(int)RoughnessIndex];
if (Rex > 0.1) { // avoid zero and crazy small denominators
Real64 tmp = std::log(1.0 + GrLn / pow_2(Rex));
Real64 tmp = std::log1p(GrLn / pow_2(Rex));
eta = tmp / (1.0 + tmp);
} else {
eta = 1.0; // forced convection gone because no wind
Expand Down

4 comments on commit 4b4da6c

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-ConvectionCoefficients-log1p (rraustad) - Win64-Windows-10-VisualStudio-16: OK (2871 of 2871 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-ConvectionCoefficients-log1p (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3704 of 3706 tests passed, 3 test warnings)

Messages:\n

  • 5 tests had: ESO small diffs.
  • 3 tests had: EIO diffs.
  • 2 tests had: MTR small diffs.
  • 2 tests had: SSZ small diffs.
  • 2 tests had: ZSZ small diffs.
  • 3 tests had: Table small diffs.
  • 2 tests had: Table string diffs.

Failures:\n

regression Test Summary

  • Passed: 811
  • Failed: 2

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-ConvectionCoefficients-log1p (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2077 of 2077 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-ConvectionCoefficients-log1p (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (797 of 797 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.