Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jmarrec authored Nov 25, 2024
1 parent c62af83 commit 56150e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_develop_commits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
id: build
working-directory: ./build
run: |
echo "::add-matcher::.github/workflows/cpp-problem-matcher.json"
echo "::add-matcher::../.github/workflows/cpp-problem-matcher.json"
cmake --build . -j ${{ matrix.nproc }} --config Release
echo "::remove-matcher owner=gcc-problem-matcher::"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ jobs:
id: branch_build
working-directory: ./branch/build
run: |
echo "::add-matcher::.github/workflows/cpp-problem-matcher.json"
echo "::add-matcher::../../.github/workflows/cpp-problem-matcher.json"
cmake --build . -j ${{ matrix.nproc }} --config Release
echo "::remove-matcher owner=gcc-problem-matcher::"
Expand Down

4 comments on commit 56150e3

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc_problem_matcher (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.2-UnitTestsCoverage-RelWithDebInfo: OK (2099 of 2099 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc_problem_matcher (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.2: OK (2917 of 2917 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc_problem_matcher (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.2-IntegrationCoverage-RelWithDebInfo: OK (801 of 801 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc_problem_matcher (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2895 of 2895 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.