Skip to content

Commit

Permalink
One more standard rating tweak, try to suppress psych warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Myoldmopar committed Oct 31, 2023
1 parent cf9d23f commit 768e703
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/EnergyPlus/Psychrometrics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,11 @@ namespace Psychrometrics {

DISABLE_WARNING_PUSH
DISABLE_WARNING_STRICT_ALIASING
// cppcheck-suppress invalidPointerCast
// cppcheck-suppress[invalidPointerCast,unmatchedSuppression]
std::uint64_t Tdb_tag = *reinterpret_cast<std::uint64_t const *>(&Tdb) >> Grid_Shift;
// cppcheck-suppress invalidPointerCast
// cppcheck-suppress[invalidPointerCast,unmatchedSuppression]
std::uint64_t W_tag = *reinterpret_cast<std::uint64_t const *>(&W) >> Grid_Shift;
// cppcheck-suppress invalidPointerCast
// cppcheck-suppress[invalidPointerCast,unmatchedSuppression]
std::uint64_t Pb_tag = *reinterpret_cast<std::uint64_t const *>(&Pb) >> Grid_Shift;
DISABLE_WARNING_POP

Expand Down
4 changes: 2 additions & 2 deletions src/EnergyPlus/StandardRatings.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5063,13 +5063,13 @@ namespace StandardRatings {
} else if (bl >= q_full) {
// CASE 3 : 11.2.2.3.3 AHRI-2023
// Building Load is greater than the capacity of the unit at the Full Compressor Speed, q_full <= bl or (bl >= q_full:)
if (t > (-15) && t <= (-8.33)) {
if (t > (-15) && t < (-8.33)) {
Real64 t_ratio = (t - (-15)) / ((-8.33) - (-15));
// Equation 11.203 AHRI-2023
q_full = q_H4_full + (q_H3_full - q_H4_full) * t_ratio;
// Equation 11.204 AHRI-2023
p_full = p_H4_full + (p_H3_full - p_H4_full) * t_ratio;
} else if (t < (-15)) {
} else if (t <= (-15)) {
Real64 t_ratio = (t - (-15)) / (8.33 - (-8.33));
// Equation 11.205 AHRI-2023
q_full = q_H4_full + (q_H1_full - q_H3_full) * t_ratio;
Expand Down

6 comments on commit 768e703

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanupsOnlyOct2023 (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2750 of 2750 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanupsOnlyOct2023 (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3563 of 3577 tests passed, 0 test warnings)

Messages:\n

  • 14 tests had: EIO diffs.
  • 14 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 791
  • Failed: 14

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanupsOnlyOct2023 (Myoldmopar) - x86_64-MacOS-10.17-clang-14.0.0: OK (3522 of 3536 tests passed, 0 test warnings)

Messages:\n

  • 14 tests had: EIO diffs.
  • 14 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 771
  • Failed: 14

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanupsOnlyOct2023 (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2750 of 2750 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanupsOnlyOct2023 (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1958 of 1964 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1473
  • Subprocess aborted: 6

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanupsOnlyOct2023 (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (734 of 789 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 734
  • Failed: 55

Build Badge Test Badge Coverage Badge

Please sign in to comment.