Skip to content

Commit

Permalink
Correct new DX coil no load supply air flow rate
Browse files Browse the repository at this point in the history
  • Loading branch information
rraustad committed Dec 5, 2023
1 parent 4ccd87a commit 7842e9f
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions src/EnergyPlus/UnitarySystem.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2114,18 +2114,21 @@ namespace UnitarySystems {
this->m_NoLoadAirFlowRateRatio = min(NoLoadCoolingAirFlowRateRatio, NoLoadHeatingAirFlowRateRatio);
}
} else {
if (this->m_CoolingCoilType_Num == DataHVACGlobals::Coil_CoolingAirToAirVariableSpeed ||
this->m_HeatingCoilType_Num == DataHVACGlobals::Coil_HeatingAirToAirVariableSpeed) {
if (this->m_CoolCoilExists && this->m_CoolingCoilType_Num == DataHVACGlobals::Coil_CoolingAirToAirVariableSpeed) {
if (this->m_CoolCoilExists || this->m_HeatCoilExists) {
if (this->m_CoolingCoilType_Num == DataHVACGlobals::Coil_CoolingAirToAirVariableSpeed) {
Real64 MaxSpeedFlowRate =
state.dataVariableSpeedCoils->VarSpeedCoil(this->m_CoolingCoilIndex)
.MSRatedAirVolFlowRate(state.dataVariableSpeedCoils->VarSpeedCoil(this->m_CoolingCoilIndex).NumOfSpeeds);
if (MaxSpeedFlowRate > 0.0) {
NoLoadCoolingAirFlowRateRatio =
state.dataVariableSpeedCoils->VarSpeedCoil(this->m_CoolingCoilIndex).MSRatedAirVolFlowRate(1) / MaxSpeedFlowRate;
}
} else if (this->m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_Cooling) {
NoLoadCoolingAirFlowRateRatio = state.dataCoilCooingDX->coilCoolingDXs[this->m_CoolingCoilIndex]
.performance.normalMode.speeds[0]
.original_input_specs.evaporator_air_flow_fraction;
}
if (this->m_HeatCoilExists && this->m_HeatingCoilType_Num == DataHVACGlobals::Coil_HeatingAirToAirVariableSpeed) {
if (this->m_HeatingCoilType_Num == DataHVACGlobals::Coil_HeatingAirToAirVariableSpeed) {
Real64 MaxSpeedFlowRate =
state.dataVariableSpeedCoils->VarSpeedCoil(this->m_HeatingCoilIndex)
.MSRatedAirVolFlowRate(state.dataVariableSpeedCoils->VarSpeedCoil(this->m_HeatingCoilIndex).NumOfSpeeds);
Expand Down

5 comments on commit 7842e9f

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10312-No-Load-Supply-Air-Flow-Rate-using-VS-coils (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3583 of 3587 tests passed, 0 test warnings)

Messages:\n

  • 4 tests had: EIO diffs.
  • 4 tests had: Table big diffs.
  • 2 tests had: ERR diffs.
  • 3 tests had: ESO big diffs.
  • 3 tests had: MTR big diffs.

Failures:\n

regression Test Summary

  • Passed: 802
  • Failed: 4

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10312-No-Load-Supply-Air-Flow-Rate-using-VS-coils (rraustad) - x86_64-MacOS-10.17-clang-14.0.0: OK (3542 of 3546 tests passed, 0 test warnings)

Messages:\n

  • 4 tests had: EIO diffs.
  • 4 tests had: Table big diffs.
  • 2 tests had: ERR diffs.
  • 3 tests had: ESO big diffs.
  • 3 tests had: MTR big diffs.

Failures:\n

regression Test Summary

  • Passed: 782
  • Failed: 4

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10312-No-Load-Supply-Air-Flow-Rate-using-VS-coils (rraustad) - Win64-Windows-10-VisualStudio-16: OK (2759 of 2759 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10312-No-Load-Supply-Air-Flow-Rate-using-VS-coils (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1972 of 1972 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10312-No-Load-Supply-Air-Flow-Rate-using-VS-coils (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (790 of 790 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.