Skip to content

Commit

Permalink
Fix EIO string diff
Browse files Browse the repository at this point in the history
  • Loading branch information
amirroth committed Oct 26, 2023
1 parent 0fe27c3 commit 9129ef6
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/EnergyPlus/WeatherManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3508,7 +3508,12 @@ namespace Weather {
print(state.files.eio, "{:.1R},", AVSC);
print(state.files.eio, "{:.2R},", designDay.EquationOfTime * 60.0);
print(state.files.eio, "{:.1R},", std::asin(designDay.SinSolarDeclinAngle) / Constant::DegToRadians);
print(state.files.eio, "{}\n", DesDaySolarModelNames[(int)desDayInput.solarModel]);

// Why have a different string for "Schedule" here than the one used for input? Really, why?
static constexpr std::array<std::string_view, (int)DesDaySolarModel::Num> DesDaySolarModelStrings = {
"ASHRAEClearSky", "ZhangHuang", "User supplied beam/diffuse from schedules", "ASHRAETau", "ASHRAETau2017" };

print(state.files.eio, "{}\n", DesDaySolarModelStrings[(int)desDayInput.solarModel]);
}

// Must set up weather values for Design Day. User can specify the "humidity indicator" as
Expand Down

5 comments on commit 9129ef6

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weather1 (amirroth) - x86_64-MacOS-10.17-clang-14.0.0: OK (3535 of 3535 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weather1 (amirroth) - Win64-Windows-10-VisualStudio-16: OK (2749 of 2749 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weather1 (amirroth) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3575 of 3576 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 804
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weather1 (amirroth) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1963 of 1963 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weather1 (amirroth) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (789 of 789 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.