10677 Fix of BB Crash

This fix avoids the hard crash that is taking place in the defect IDF by not doing sizing when sizing is not required for the convective water baseboard unit.
NREL · Aug 30, 2024 · 937345c · 937345c · nrel-bot-2b · Aug 30, 2024
1 parent a7fe8f7
commit 937345c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/EnergyPlus/BaseboardRadiator.cc b/src/EnergyPlus/BaseboardRadiator.cc
@@ -418,6 +418,8 @@ namespace BaseboardRadiator {
 
                 thisBaseboard.ZonePtr = DataZoneEquipment::GetZoneEquipControlledZoneNum(
                     state, DataZoneEquipment::ZoneEquipType::BaseboardConvectiveWater, thisBaseboard.EquipID);
+
+                thisBaseboard.resetSizingFlagBasedOnInput(state); // set MySizeFlag to false if no autosizing is being done
             }
 
             if (ErrorsFound) {
@@ -941,6 +943,20 @@ namespace BaseboardRadiator {
         }
     }
 
+    void BaseboardParams::resetSizingFlagBasedOnInput(EnergyPlusData &state)
+    {
+        // this->MySizeFlag defaults to true.  Set to false if no sizing is requested.
+        // Condition 1: Is UA hardwired (not autosized)?
+        // Condition 2: Is max flow rate hardwired (not autosized)?
+        // Condition 3: Is EITHER capacity used and hardwired (not autosized) OR capacity per floor area used?
+        // If YES to all three, then this unit does not need to be autosized and the sizing flag needs to be set to false.
+        if ((this->UA != DataSizing::AutoSize) && (this->WaterVolFlowRateMax != DataSizing::AutoSize) &&
+            (((this->HeatingCapMethod == DataSizing::HeatingDesignCapacity) && (this->ScaledHeatingCapacity != DataSizing::AutoSize)) ||
+             (this->HeatingCapMethod == DataSizing::CapacityPerFloorArea))) {
+            this->MySizeFlag = false;
+        }
+    }
+
     void SimHWConvective(EnergyPlusData &state, int &BaseboardNum, Real64 &LoadMet)
     {
         // SUBROUTINE INFORMATION:

diff --git a/src/EnergyPlus/BaseboardRadiator.hh b/src/EnergyPlus/BaseboardRadiator.hh
@@ -107,6 +107,8 @@ namespace BaseboardRadiator {
         void InitBaseboard(EnergyPlusData &state, int baseboardNum);
 
         void SizeBaseboard(EnergyPlusData &state, int baseboardNum);
+
+        void resetSizingFlagBasedOnInput(EnergyPlusData &state);
     };
 
     void SimBaseboard(