Skip to content

Commit

Permalink
Merge pull request #10877 from NREL/CppCheck-expm-FluidCoolers
Browse files Browse the repository at this point in the history
CppCheck expm1 on FluidCoolers
  • Loading branch information
Myoldmopar authored Jan 9, 2025
2 parents 3bc09c0 + c5fe4ab commit b3ae9b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/EnergyPlus/FluidCoolers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1888,7 +1888,7 @@ void CalcFluidCoolerOutlet(
Real64 NumTransferUnits = UAdesign / CapacityRatioMin;
Real64 ETA = std::pow(NumTransferUnits, 0.22);
Real64 A = CapacityRatio * NumTransferUnits / ETA;
Real64 effectiveness = 1.0 - std::exp((std::exp(-A) - 1.0) / (CapacityRatio / ETA));
Real64 effectiveness = 1.0 - std::exp(std::expm1(-A) / (CapacityRatio / ETA));

// calculate water to air heat transfer
_Qactual = effectiveness * CapacityRatioMin * (_InletWaterTemp - InletAirTemp);
Expand Down

3 comments on commit b3ae9b9

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-24.04-gcc-13.3: OK (2919 of 2919 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-24.04-gcc-13.3-UnitTestsCoverage-RelWithDebInfo: OK (2101 of 2101 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-24.04-gcc-13.3-IntegrationCoverage-RelWithDebInfo: OK (801 of 801 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.