Skip to content

Commit

Permalink
Fix transition
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu committed Nov 20, 2023
1 parent 568d873 commit bce326d
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/Transition/CreateNewIDFUsingRulesV24_1_0.f90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
CHARACTER(20), DIMENSION(4) :: HxEffectAt100Airflow
CHARACTER(MaxNameLength + 2), DIMENSION(4) :: HxTableName
LOGICAL :: tableAdded
LOGICAL :: tableIndependentVarAdded
LOGICAL :: tableIndependentVarAdded = .false.
CHARACTER(10) :: tableID
REAL :: effect75
REAL :: effect100
Expand Down Expand Up @@ -456,24 +456,22 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
CurArgs = 12
tableAdded = .true.
CALL WriteOutIDFLines(DifLfn,ObjectName,CurArgs,OutArgs,NwFldNames,NwFldUnits)
Written=.true.
ENDIF
END DO

! add independent variables used in the tables
IF (tableAdded .AND. .NOT. tableIndependentVarAdded) THEN
tableIndependentVarAdded = .false.
tableIndependentVarAdded = .true.
ObjectName='Table:IndependentVariableList'
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
OutArgs(1) = 'effectiveness_IndependentVariableList'
OutArgs(2) = 'HxAirFlowRatio'
CurArgs = 2
CALL WriteOutIDFLines(DifLfn,ObjectName,CurArgs,OutArgs,NwFldNames,NwFldUnits)
Written=.true.

ObjectName='Table:IndependentVariableList'
ObjectName='Table:IndependentVariable'
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
OutArgs(1) = 'HxAirFlowRatio'
OutArgs(1) = 'HxAirFlowRatio' ! Name
OutArgs(2) = 'Linear' ! Interpolation Method
OutArgs(3) = 'Linear' ! Extrapolation Method
OutArgs(4) = '0.0' ! Minimum Value
Expand All @@ -487,8 +485,8 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
OutArgs(12) = '1.0' ! Value 2
CurArgs = 12
CALL WriteOutIDFLines(DifLfn,ObjectName,CurArgs,OutArgs,NwFldNames,NwFldUnits)
Written=.true.
ENDIF
Written=.true.

! If your original object starts with I, insert the rules here

Expand Down

5 comments on commit bce326d

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labHeatExchangerNFP (Unknown) - x86_64-MacOS-10.17-clang-14.0.0: OK (3515 of 3540 tests passed, 6 test warnings)

Messages:\n

  • 24 tests had: AUD diffs.
  • 15 tests had: EIO diffs.
  • 21 tests had: ESO small diffs.
  • 13 tests had: MTR small diffs.
  • 25 tests had: Table big diffs.
  • 5 tests had: RDD diffs.
  • 6 tests had: Table small diffs.
  • 3 tests had: IDF diffs.
  • 1 test had: ESO big diffs.

Failures:\n

regression Test Summary

  • Passed: 761
  • Failed: 25

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labHeatExchangerNFP (Unknown) - Win64-Windows-10-VisualStudio-16: Build Failed

Failures:\n

API Test Summary

  • Failed: 10
  • notrun: 5

ConvertInputFormat Test Summary

  • Failed: 4
  • notrun: 1

integration Test Summary

  • Passed: 2
  • Failed: 787

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labHeatExchangerNFP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1966 of 1966 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labHeatExchangerNFP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (790 of 790 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labHeatExchangerNFP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3541 of 3581 tests passed, 718 test warnings)

Messages:\n

  • 758 tests had: AUD diffs.
  • 743 tests had: RDD diffs.
  • 44 tests had: EIO diffs.
  • 118 tests had: MTD diffs.
  • 40 tests had: Table big diffs.
  • 31 tests had: ESO small diffs.
  • 15 tests had: MTR small diffs.
  • 2 tests had: BND diffs.
  • 3 tests had: ESO big diffs.
  • 2 tests had: MDD diffs.
  • 3 tests had: ERR diffs.
  • 3 tests had: IDF diffs.
  • 3 tests had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 766
  • Failed: 40

Build Badge Test Badge

Please sign in to comment.