Skip to content

Commit

Permalink
clang
Browse files Browse the repository at this point in the history
  • Loading branch information
rraustad committed Dec 2, 2024
1 parent 5db0a46 commit d44704c
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions src/EnergyPlus/SurfaceGeometry.cc
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,7 @@ namespace SurfaceGeometry {
// RE-ENGINEERED November 1997 (RKS,LKL)

// PURPOSE OF THIS SUBROUTINE:
// This subroutine controls the processing of detached shadowing and
// zone surfaces for computing their vertices.
// This subroutine controls the processing of detached shadowing and zone surfaces for computing their vertices.

static constexpr std::string_view RoutineName("SetUpZoneGeometry: ");

Expand Down Expand Up @@ -1021,7 +1020,6 @@ namespace SurfaceGeometry {
bool subSurfaceError(false);
bool errFlag;

int iTmp1;
bool izConstDiff; // differences in construction for IZ surfaces
bool izConstDiffMsg; // display message about hb diffs only once.

Expand Down Expand Up @@ -2531,7 +2529,7 @@ namespace SurfaceGeometry {
} // for (SurfNum)

// Check for IRT surfaces in invalid places.
iTmp1 = 0;
int iTmp1 = 0;
if (std::any_of(state.dataConstruction->Construct.begin(),
state.dataConstruction->Construct.end(),
[](Construction::ConstructionProps const &e) { return e.TypeIsIRT; })) {
Expand Down Expand Up @@ -15118,11 +15116,11 @@ namespace SurfaceGeometry {
// METHODOLOGY EMPLOYED:
// Transform the surface into an equivalent rectangular surface with the same area and aspect ratio.

Real64 AspectRatio; // Aspect ratio
Real64 WidthEff; // Effective width of the surface
Real64 WidthMax; // X difference between the vertex on the most left and the one on the most right
Real64 HeightEff; // Effective height of the surface
Real64 HeightMax; // Y difference between the lowest and highest vertices
Real64 AspectRatio; // Aspect ratio
Real64 WidthEff; // Effective width of the surface
Real64 WidthMax; // X difference between the vertex on the most left and the one on the most right
Real64 HeightEff; // Effective height of the surface
Real64 HeightMax; // Y difference between the lowest and highest vertices
Real64 Xp;
Real64 Yp;
Real64 Zp;
Expand Down

3 comments on commit d44704c

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-SurfaceGeometry (rraustad) - x86_64-Linux-Ubuntu-24.04-gcc-13.2: OK (2917 of 2917 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-SurfaceGeometry (rraustad) - x86_64-Linux-Ubuntu-24.04-gcc-13.2-UnitTestsCoverage-RelWithDebInfo: OK (2064 of 2099 tests passed, 0 test warnings)

Failures:\n

API Test Summary

  • Failed: 10
  • notrun: 5

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CppCheck-SurfaceGeometry (rraustad) - x86_64-Linux-Ubuntu-24.04-gcc-13.2-IntegrationCoverage-RelWithDebInfo: OK (801 of 801 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.