Merge pull request #10452 from NREL/RAFN-CheckEquipName-Issue

Refactor RAFN CheckEquipName for forced air zone equipment
NREL · Jul 25, 2024 · e85c6ac · e85c6ac · nrel-bot-3 · Jul 25, 2024
2 parents 980120d + 5059ae9
commit e85c6ac
Show file tree

Hide file tree

Showing 30 changed files with 655 additions and 146 deletions.
diff --git a/idd/Energy+.idd.in b/idd/Energy+.idd.in
@@ -21309,7 +21309,8 @@ RoomAir:Node:AirflowNetwork:HVACEquipment,
       \key ZoneHVAC:IdealLoadsAirSystem
       \key ZoneHVAC:RefrigerationChillerSet
       \key Fan:ZoneExhaust
-      \key WaterHeater:HeatPump
+      \key WaterHeater:HeatPump:PumpedCondenser
+      \key WaterHeater:HeatPump:WrappedCondenser
       \key AirTerminal:DualDuct:ConstantVolume
       \key AirTerminal:DualDuct:VAV
       \key AirTerminal:SingleDuct:ConstantVolume:Reheat
@@ -21359,7 +21360,8 @@ RoomAir:Node:AirflowNetwork:HVACEquipment,
       \key ZoneHVAC:IdealLoadsAirSystem
       \key ZoneHVAC:RefrigerationChillerSet
       \key Fan:ZoneExhaust
-      \key WaterHeater:HeatPump
+      \key WaterHeater:HeatPump:PumpedCondenser
+      \key WaterHeater:HeatPump:WrappedCondenser
       \key AirTerminal:DualDuct:ConstantVolume
       \key AirTerminal:DualDuct:VAV
       \key AirTerminal:SingleDuct:ConstantVolume:Reheat

diff --git a/src/EnergyPlus/FanCoilUnits.cc b/src/EnergyPlus/FanCoilUnits.cc
@@ -4419,6 +4419,23 @@ namespace FanCoilUnits {
         }
     }
 
+    int getEqIndex(EnergyPlusData &state, std::string_view CompName)
+    {
+        if (state.dataFanCoilUnits->GetFanCoilInputFlag) {
+            GetFanCoilUnits(state);
+            state.dataFanCoilUnits->GetFanCoilInputFlag = false;
+        }
+
+        for (int FanCoilIndex = 1; FanCoilIndex <= state.dataFanCoilUnits->NumFanCoils; ++FanCoilIndex) {
+            auto &fanCoil = state.dataFanCoilUnits->FanCoil(FanCoilIndex);
+            if (Util::SameString(fanCoil.Name, CompName)) {
+                return FanCoilIndex;
+            }
+        }
+
+        return 0;
+    }
+
 } // namespace FanCoilUnits
 
 } // namespace EnergyPlus
diff --git a/src/EnergyPlus/FanCoilUnits.hh b/src/EnergyPlus/FanCoilUnits.hh
@@ -319,7 +319,7 @@ namespace FanCoilUnits {
 
     void ReportFanCoilUnit(EnergyPlusData &state, int FanCoilNum); // number of the current fan coil unit being simulated
 
-    int GetFanCoilZoneInletAirNode(EnergyPlusData &state, int FanCoilNum);
+    int GetFanCoilZoneInletAirNode(EnergyPlusData &state, int const FanCoilNum);
 
     int GetFanCoilOutAirNode(EnergyPlusData &state, int FanCoilNum);
 
@@ -380,6 +380,7 @@ namespace FanCoilUnits {
                                               int WaterControlNode,
                                               Real64 MinWaterFlow);
 
+    int getEqIndex(EnergyPlusData &state, std::string_view CompName);
 } // namespace FanCoilUnits
 
 struct FanCoilUnitsData : BaseGlobalStruct

diff --git a/src/EnergyPlus/HVACStandAloneERV.cc b/src/EnergyPlus/HVACStandAloneERV.cc
@@ -1685,4 +1685,20 @@ bool GetStandAloneERVNodeNumber(EnergyPlusData &state, int const NodeNumber)
     return false;
 }
 
+int getEqIndex(EnergyPlusData &state, std::string_view CompName)
+{
+    if (state.dataHVACStandAloneERV->GetERVInputFlag) {
+        GetStandAloneERV(state);
+        state.dataHVACStandAloneERV->GetERVInputFlag = false;
+    }
+
+    for (int StandAloneERVNum = 1; StandAloneERVNum <= state.dataHVACStandAloneERV->NumStandAloneERVs; StandAloneERVNum++) {
+        if (Util::SameString(CompName, state.dataHVACStandAloneERV->StandAloneERV(StandAloneERVNum).Name)) {
+            return StandAloneERVNum;
+            break;
+        }
+    }
+    return 0;
+}
+
 } // namespace EnergyPlus::HVACStandAloneERV
diff --git a/src/EnergyPlus/HVACStandAloneERV.hh b/src/EnergyPlus/HVACStandAloneERV.hh
@@ -186,6 +186,8 @@ namespace HVACStandAloneERV {
 
     bool GetStandAloneERVNodeNumber(EnergyPlusData &state, int NodeNumber);
 
+    int getEqIndex(EnergyPlusData &state, std::string_view CompName);
+
 } // namespace HVACStandAloneERV
 
 struct HVACStandAloneERVData : BaseGlobalStruct

diff --git a/src/EnergyPlus/HVACVariableRefrigerantFlow.cc b/src/EnergyPlus/HVACVariableRefrigerantFlow.cc
@@ -10757,6 +10757,21 @@ int GetVRFTUReturnAirNode(EnergyPlusData &state, int const VRFTUNum)
     }
 }
 
+int getEqIndex(EnergyPlusData &state, std::string_view VRFTUName)
+{
+    if (state.dataHVACVarRefFlow->GetVRFInputFlag) {
+        GetVRFInput(state);
+        state.dataHVACVarRefFlow->GetVRFInputFlag = false;
+    }
+
+    for (int VRFTUNum = 1; VRFTUNum <= state.dataHVACVarRefFlow->NumVRFTU; VRFTUNum++) {
+        if (Util::SameString(VRFTUName, state.dataHVACVarRefFlow->VRFTU(VRFTUNum).Name)) {
+            return VRFTUNum;
+        }
+    }
+    return 0;
+}
+
 void getVRFTUZoneLoad(
     EnergyPlusData &state, int const VRFTUNum, Real64 &zoneLoad, Real64 &LoadToHeatingSP, Real64 &LoadToCoolingSP, bool const InitFlag)
 {

diff --git a/src/EnergyPlus/HVACVariableRefrigerantFlow.hh b/src/EnergyPlus/HVACVariableRefrigerantFlow.hh
@@ -976,6 +976,8 @@ namespace HVACVariableRefrigerantFlow {
                                    Real64 const T_suc // Compressor suction temperature Te' [C]
     );
 
+    int getEqIndex(EnergyPlusData &state, std::string_view VRFTUName);
+
 } // namespace HVACVariableRefrigerantFlow
 
 struct HVACVarRefFlowData : BaseGlobalStruct

diff --git a/src/EnergyPlus/HybridUnitaryAirConditioners.cc b/src/EnergyPlus/HybridUnitaryAirConditioners.cc
@@ -1366,6 +1366,23 @@ int GetHybridUnitaryACReturnAirNode(EnergyPlusData &state, int const CompNum)
     return GetHybridUnitaryACReturnAirNode;
 }
 
+int getHybridUnitaryACIndex(EnergyPlusData &state, std::string_view CompName)
+{
+    bool errFlag = false;
+    if (state.dataHybridUnitaryAC->GetInputZoneHybridEvap) {
+        GetInputZoneHybridUnitaryAirConditioners(state, errFlag);
+        state.dataHybridUnitaryAC->GetInputZoneHybridEvap = false;
+    }
+
+    for (int UnitLoop = 1; UnitLoop <= state.dataHybridUnitaryAC->NumZoneHybridEvap; ++UnitLoop) {
+        if (Util::SameString(state.dataHybridUnitaryAC->ZoneHybridUnitaryAirConditioner(UnitLoop).Name, CompName)) {
+            return UnitLoop;
+        }
+    }
+
+    return 0;
+}
+
 //*****************************************************************************************
 
 } // namespace EnergyPlus::HybridUnitaryAirConditioners
diff --git a/src/EnergyPlus/HybridUnitaryAirConditioners.hh b/src/EnergyPlus/HybridUnitaryAirConditioners.hh
@@ -98,6 +98,8 @@ namespace HybridUnitaryAirConditioners {
 
     int GetHybridUnitaryACReturnAirNode(EnergyPlusData &state, int UnitNum);
 
+    int getHybridUnitaryACIndex(EnergyPlusData &state, std::string_view CompName);
+
 } // namespace HybridUnitaryAirConditioners
 
 struct HybridUnitaryAirConditionersData : BaseGlobalStruct

diff --git a/src/EnergyPlus/OutdoorAirUnit.cc b/src/EnergyPlus/OutdoorAirUnit.cc
@@ -2469,6 +2469,22 @@ namespace OutdoorAirUnit {
         return GetOutdoorAirUnitReturnAirNode;
     }
 
+    int getOutdoorAirUnitEqIndex(EnergyPlusData &state, std::string_view EquipName)
+    {
+        if (state.dataOutdoorAirUnit->GetOutdoorAirUnitInputFlag) {
+            OutdoorAirUnit::GetOutdoorAirUnitInputs(state);
+            state.dataOutdoorAirUnit->GetOutdoorAirUnitInputFlag = false;
+        }
+
+        for (int OAUnitNum = 1; OAUnitNum <= state.dataOutdoorAirUnit->NumOfOAUnits; ++OAUnitNum) {
+            if (Util::SameString(state.dataOutdoorAirUnit->OutAirUnit(OAUnitNum).Name, EquipName)) {
+                return OAUnitNum;
+            }
+        }
+
+        return 0;
+    }
+
 } // namespace OutdoorAirUnit
 
 } // namespace EnergyPlus
diff --git a/src/EnergyPlus/OutdoorAirUnit.hh b/src/EnergyPlus/OutdoorAirUnit.hh
@@ -309,6 +309,8 @@ namespace OutdoorAirUnit {
     int GetOutdoorAirUnitZoneInletNode(EnergyPlusData &state, int OAUnitNum);
 
     int GetOutdoorAirUnitReturnAirNode(EnergyPlusData &state, int OAUnitNum);
+
+    int getOutdoorAirUnitEqIndex(EnergyPlusData &state, std::string_view EquipName);
 } // namespace OutdoorAirUnit
 
 struct OutdoorAirUnitData : BaseGlobalStruct

diff --git a/src/EnergyPlus/PurchasedAirManager.cc b/src/EnergyPlus/PurchasedAirManager.cc
@@ -3318,6 +3318,22 @@ int GetPurchasedAirReturnAirNode(EnergyPlusData &state, int const PurchAirNum)
     return GetPurchasedAirReturnAirNode;
 }
 
+int getPurchasedAirIndex(EnergyPlusData &state, std::string_view PurchAirName)
+{
+    if (state.dataPurchasedAirMgr->GetPurchAirInputFlag) {
+        GetPurchasedAir(state);
+        state.dataPurchasedAirMgr->GetPurchAirInputFlag = false;
+    }
+
+    for (int PurchAirNum = 1; PurchAirNum <= state.dataPurchasedAirMgr->NumPurchAir; ++PurchAirNum) {
+        if (Util::SameString(state.dataPurchasedAirMgr->PurchAir(PurchAirNum).Name, PurchAirName)) {
+            return PurchAirNum;
+        }
+    }
+
+    return 0;
+}
+
 Real64 GetPurchasedAirMixedAirTemp(EnergyPlusData &state, int const PurchAirNum)
 {
 

diff --git a/src/EnergyPlus/PurchasedAirManager.hh b/src/EnergyPlus/PurchasedAirManager.hh
@@ -379,6 +379,8 @@ namespace PurchasedAirManager {
 
     int GetPurchasedAirReturnAirNode(EnergyPlusData &state, int PurchAirNum);
 
+    int getPurchasedAirIndex(EnergyPlusData &state, std::string_view PurchAirName);
+
     Real64 GetPurchasedAirMixedAirTemp(EnergyPlusData &state, int PurchAirNum);
 
     Real64 GetPurchasedAirMixedAirHumRat(EnergyPlusData &state, int PurchAirNum);