Space Sizing and HVAC Part 3 #10205

mjwitte · 2023-09-06T22:19:58Z

Pull request overview

More Space sizing and HVAC - more details to follow.
Build on Extend Spaces to Sizing and HVAC #9982 and Space Sizing and HVAC part2 - Code cleanups #10174
More refactoring of internal gains:
- eliminate duplicate variables in dataHeatBal->ZoneIntGain that weren't being used in the heat balance and were simply copied to equivalent variables in dataHeatBal->ZoneRpt (and the same for space).
- accumulate zone values by summing space values instead of accumulating both from the individual internal gain objects.
- Fixed space allocation for ZoneBaseboard:OutdoorTemperatureControlled, previously if this was applied to a zone with multiple spaces, the entire load was assigned to each space instead of allocating by floor area.
Fixed "Space Heat Balance *" output variables (previously always zero).
When space heat balance is not active, set space air temperature and humidity to the zone conditions.
Use Space air temperature and humidity always (regardless of space heat balance setting) for:
- Surface heat balance
- etc.
Flesh out some SpaceHVAC features:
- SpaceHVAC:ZoneEquipmentSplitter thermostat control options and space fraction sizing
- SpaceHVAC:ZoneEquipmentMixer

ToDo

More documentation
Unit tests
Test various feature options

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…gHVACPart3

Myoldmopar · 2023-09-12T17:38:25Z

OK, still marked as draft, so I'm passing over this one for now. @mjwitte please advise if I should stop and look a little closer here before freeze.

mjwitte · 2023-09-13T16:01:07Z

@Myoldmopar I'm planning to finish this soon. It's built on #10174 which should be ready to merge first.

…gHVACPart3

mjwitte · 2023-09-20T02:14:11Z

Ok, so, essentially two lines of code needed to change. Not perfect, but much better than before.

Zone sizing stays the same with or without Do Space Heat Balance for Sizing (or Simulation) for zones that have a single space.
For zones with multiple spaces, the zone sizing changes slightly when Space Sizing is active (on the order of 1-2%).
For zones with a single space, the space sizing matches its zone sizing.

@Myoldmopar @rraustad This should be ready go now, except for some doc changes and unit tests which can be in another PR.

mjwitte · 2023-09-20T13:17:42Z

Diffs

5ZoneAirCooledWithSpaceHeatBalance - All of the Space Air * variables were zero before, now they have values.
5ZoneAirCooledWithSpacesHVAC - Lots of changes to the plumbing here, so diffs expected in sizing on down.
Small diffs on other files on the order of 1e-15 (relative) due to the changes in summing for zone-level internal gains output variables. Previously, zones and spaces summed across the individual instances of e.g. electric equipment. Now, the spaces sum the instances, and the zones sum the space values.

rraustad · 2023-09-20T14:44:33Z

Ok, so, essentially two lines of code needed to change. Not perfect, but much better than before.

Zone sizing stays the same with or without Do Space Heat Balance for Sizing (or Simulation) for zones that have a single space.

For zones with multiple spaces, the zone sizing changes slightly when Space Sizing is active (on the order of 1-2%).

For zones with a single space, the space sizing matches its zone sizing.

@Myoldmopar @rraustad This should be ready go now, except for some doc changes and unit tests which can be in another PR.

The 1-2% change for multiple spaces is either something that was fixed or something that is missing. I suspect a change like thisZoneBBHeat.CapatHighTemperature = IHGNumbers(3) * spaceFrac; would cause a diff as something fixed.

Since the "space" files show big diffs in space and zone sizing I think it would be a good idea to compare the zone sizing results to the original 5ZoneAirCooled zone sizing results as a sanity check (assuming zone equipment lines up with space equipment).

As far as other changes here, the walk-thru makes sense and the "well, I can't recall" comment reminds me of branches I have worked on in the past. Docs and unit tests in a different branch is OK with me although doc changes should accompany these changes (except that use of spaces is probably not yet wide-spread). Now that changes have settled down a final pass through code wouldn't hurt.

mjwitte · 2023-09-20T15:23:59Z

Here's a comparison of eio sizing output for 5ZoneAirCooledWithSpaceHeatBalance vs 5ZoneAirCooled. This is with one space per zone. The current 5ZoneAirCooledWithSpaces is not equivalent to 5ZoneAirCooled (it has different internal gain objects). I'll make a version that should be equivalent next.

mjwitte · 2023-09-20T16:23:55Z

Here's the sizing for 5ZoneAirCooledWithSpacesAndSameInternalGains vs 5ZoneAirCooled. There are more walls in 5ZoneAirCooledWithSpacesAndSameInternalGains so I would expect some small changes.

And here is 5ZoneAirCooledWithSpacesAndSameInternalGains with space sizing active vs no space sizing. Note how the cooling sizing changes slightly but the heating sizing is the same. That's a clue that maybe a humidity value isn't what is should be? Or some internal gain value is different? That'll have to wait for another day.

mjwitte · 2023-09-20T16:24:50Z

@Myoldmopar I see conflicts now. I'll work on that.

…gHVACPart3

mjwitte · 2023-09-20T16:49:51Z

doc changes should accompany these changes
@rraustad The main I/O Ref changes were included in Part 1 #9982 Some fine-tuning of that and adding the figure you worked on plus some Engineering Ref comments about space are needed. Not a show-stopper if those don't make it into 23.2.

…gHVACPart3

rraustad · 2023-09-20T17:11:02Z

src/EnergyPlus/DataZoneEquipment.cc

                                      thisZeqSplitter.Name,
                                      DataLoopNode::NodeFluidType::Air,
                                      DataLoopNode::ConnectionType::Outlet,
                                      NodeInputManager::CompFluidStream::Primary,
                                      objectIsParent);
+                if (thisZeqSplitter.controlSpaceIndex == thisZeqSpace.spaceIndex) {
+                    thisZeqSplitter.controlSpaceNumber = spaceCount;
+                }


Picks up the control space index (took a minute to see what this was doing).

rraustad · 2023-09-20T17:13:55Z

src/EnergyPlus/DataZoneEquipment.cc

+                                         thisSpace.fraction);
+        }
+    }
+}


Could combine these 2 switch blocks. For another day.

Hmm, the motivation to separate them was to calculate spacesTotal first, then check to see if it's zero before using it to divide. But I'm open to other suggestions (on another day).

mjwitte · 2023-09-20T17:33:30Z

src/EnergyPlus/DataSurfaces.cc

+        auto &inletNodes = (state.dataHeatBal->doSpaceHeatBalance) ? state.dataZoneEquip->spaceEquipConfig(this->spaceNum).InletNode
+                                                                   : state.dataZoneEquip->ZoneEquipConfig(Zone).InletNode;
+        for (int nodeNum : inletNodes) {
+            auto &inNode = state.dataLoopNodes->Node(state.dataZoneEquip->ZoneEquipConfig(Zone).InletNode(nodeNum));


Due to the comment above, I realize this line is incorrect and should have caused a subscript error, but this code is not covered in the integration tests, how is that? Nothing in the integration tests ever sets
state.dataSurface->SurfTAirRef(SurfNum) = DataSurfaces::RefAirTemp::ZoneSupplyAirTemp

Anyways, will address this shortly along with other comments.

rraustad · 2023-09-20T17:39:38Z

src/EnergyPlus/DataZoneEquipment.cc

+                latentRatio = (state.dataZoneEnergyDemand->spaceSysMoistureDemand(maxSpaceIndex).RemainingOutputRequired /
+                               thisZoneMoistureDemand.RemainingOutputRequired) /
+                              maxSpaceFrac;
+            }


It took me a minute to see why you were saving the original zone loads and I see now the space loads can be different depending on how the fraction is derived.

Yeah, this was an attempt to avoid having e v-e r-y piece of HVAC equipment look to see if it should be controlling to the zone load or a specific space load. It' working, kindof, but the controls are not as precise as I expected. Room for improvement in the next cycle.

rraustad · 2023-09-20T17:41:08Z

src/EnergyPlus/HVACManager.cc

+        thisSpaceHB.ZT = thisSpaceHB.MAT;
+        // save for use with thermal comfort control models (Fang, Pierce, and KSU)
+        thisSpaceHB.ZTAV = 0.0;
+        thisSpaceHB.airHumRatAvg = 0.0;


Since zone is now a space sum, this/these is/are always executed.

rraustad · 2023-09-20T18:14:17Z

src/EnergyPlus/ZoneTempPredictorCorrector.cc

                state.dataZoneTempPredictorCorrector->spaceHeatBalance(spaceNum).predictSystemLoad(
                    state, ShortenTimeStepSys, UseZoneTimeStepHistory, PriorTimeStep, zoneNum, spaceNum);
+            } else if (ShortenTimeStepSys) {
+                state.dataZoneTempPredictorCorrector->spaceHeatBalance(spaceNum).MAT = thisZoneHB.MAT;
+                state.dataZoneTempPredictorCorrector->spaceHeatBalance(spaceNum).airHumRat = thisZoneHB.airHumRat;


Won't the spaces be able to float to temperatures other than the zone MAT? i.e., shouldn't the space MAT be the last time step space MAT?

Won't the spaces be able to float to temperatures other than the zone MAT? i.e., shouldn't the space MAT be the last time step space MAT?

This is an else if after if (state.dataHeatBal->doSpaceHeatBalance) so it only fires if there's no space heat balance active. Yes, this has gotten a bit messy. By moving surfaces, etc. to use space air temp and humrat (again to avoid having ifs all over the place to select space or zone), if space heat balance is not active, the space conditions need to stay in synch with the zone conditions. So any time the zone temps get moved around, the space temps need to be reset. I'd love to come up with a cleaner approach.

…gHVACPart3

rraustad · 2023-09-20T18:18:27Z

src/EnergyPlus/ZoneTempPredictorCorrector.cc

+                thisSpaceHB.MAT = thisZoneHB.MAT;
+                thisSpaceHB.airHumRat = thisZoneHB.airHumRat;
+                thisSpaceHB.airRelHum = thisZoneHB.airRelHum;
+                // thisSpaceHB.ZTAVComf = thisZoneHB.ZTAVComf;


This else section makes sense when no space HB is performed.

rraustad · 2023-09-20T18:20:17Z

src/EnergyPlus/SizingManager.cc

+            thisSpaceHVACMixer.size(state);
+        }
+    }
+


A little out of the ordinary where sizing occurs on the call to each object, but OK, this happens after system sizing so space splitter/mixer can be sized.

A little out of the ordinary where sizing occurs on the call to each object, but OK, this happens after system sizing so space splitter/mixer can be sized.

Yah, fer sure dat. This was a bit of a punt. Would love a better suggestion from the sizing guru, for another day.

rraustad · 2023-09-20T18:26:39Z

@Myoldmopar I have made another pass. Other than the few changes/conflicts @mjwitte is making now, this branch appears ready to merge. I wonder if the one thing @mjwitte found today with subscript error would change the diff's compared to 5ZoneAirCooled? Those diff's looked reasonable. As for heating diff's being small, the heating DesignDay uses a constant outdoor temperature so storage terms are negligable. Comparing the spaces zone sizing to zone sizing of 5ZoneAirCooled is a good future check.

rraustad · 2023-09-20T18:27:55Z

src/EnergyPlus/DataSurfaces.cc

@@ -251,7 +251,7 @@ Real64 SurfaceData::getInsideAirTemperature(EnergyPlusData &state, const int t_S
        auto &inletNodes = (state.dataHeatBal->doSpaceHeatBalance) ? state.dataZoneEquip->spaceEquipConfig(this->spaceNum).InletNode
                                                                   : state.dataZoneEquip->ZoneEquipConfig(Zone).InletNode;
        for (int nodeNum : inletNodes) {
-            auto &inNode = state.dataLoopNodes->Node(state.dataZoneEquip->ZoneEquipConfig(Zone).InletNode(nodeNum));
+            auto &inNode = state.dataLoopNodes->Node(nodeNum);


Oh dear, yeah, I missed that entirely.

In the unit test that covers this, there just happens to be 4 inlet nodes, and the node numbers are 1-4, so it worked. I'll try to remember to improve that unit test (all of the inlet node conditions are the same currently, so it could be a better test).

mjwitte · 2023-09-20T18:29:49Z

@Myoldmopar @rraustad Conflicts resolved, updated with develop, comments addressed or responded to or deferred. This should be the final commit assuming CI comes back clean (except for the noted diffs.

Myoldmopar · 2023-09-20T19:36:00Z

Well, Windows came back clean, as expected. Mac should be done very soon I expect.

Myoldmopar · 2023-09-20T20:23:15Z

Mac came back exactly as planned, assuming Linux doesn't find anything weird, this will merge later. Thanks for this @mjwitte !

mjwitte added 4 commits August 31, 2023 16:52

InitInternalHeatGains shortcuts and remove excess loop

208abe7

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

dbc3788

…gHVACPart3

Space - Set space temps to zone temps if no spaceHB

c5c95f3

Space - Move internal gains to space conditions

dd5e82b

mjwitte added the NewFeature Includes code to add a new feature to EnergyPlus label Sep 6, 2023

mjwitte added 15 commits September 7, 2023 09:48

remove unused

d3b014b

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

7d80e78

…gHVACPart3

InternalHeatGains merge cleanup

9cb97fc

Space - More space conditions to zone conditions if no spaceHB

dc204b9

InternalHeatGains refactor reporting and fix BBHeat space fraction

2d87d47

Eliminate duplicate internal gain reporting variables

6f45e07

Use Space conditions - HAMT surface balance

ce03c1b

Use Space conditions - DataSurfaces.cc

1e922e0

Use Space conditions - ConvectionCoefficients.cc part 1

c653a79

InternalHeatGains refactor more zeroing

c5cb1de

Use Space conditions - update spaces ZTAV and airHumRatAvg

055112f

Use Space conditions - ConvectionCoefficients.cc part 2

4c20979

InternalHeatGains refactor revert ITEq zeroing

b5b90cc

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

7e58b2e

…gHVACPart3

Revert-Use Space conditions - DataSurfaces.cc

a7da5f0

Use Space conditions - ConvectionCoefficients.cc part 3

6038695

mjwitte added this to the EnergyPlus 23.2 milestone Sep 13, 2023

mjwitte added 6 commits September 13, 2023 13:59

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

1a65499

…gHVACPart3

Use Space conditions - HeatBalanceSurfaceManager

313ebc6

Space HB - Calc space air report variables

cde8ee5

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

6c25a00

…gHVACPart3

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

8a88ca4

…gHVACPart3

cleanup

52d936e

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

3af26a9

…gHVACPart3

mjwitte added 2 commits September 20, 2023 12:07

Merge repairs

06941cf

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

60fa04e

…gHVACPart3

rraustad reviewed Sep 20, 2023

View reviewed changes

mjwitte commented Sep 20, 2023

View reviewed changes

mjwitte self-assigned this Sep 20, 2023

rraustad reviewed Sep 20, 2023

View reviewed changes

Merge remote-tracking branch 'remotes/origin/develop' into SpaceSizin…

fd0a91f

…gHVACPart3

rraustad reviewed Sep 20, 2023

View reviewed changes

Space HVAC - Fix supply nodes

96076f8

rraustad reviewed Sep 20, 2023

View reviewed changes

Myoldmopar merged commit e7398af into develop Sep 21, 2023

Myoldmopar deleted the SpaceSizingHVACPart3 branch September 21, 2023 02:17

mjwitte mentioned this pull request Sep 22, 2023

Space Sizing and HVAC Documentation and Unit Test Updates #10239

Merged

26 tasks

mjwitte mentioned this pull request Jun 17, 2024

Space Sizing and HVAC Part 4 #10566

Merged

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Space Sizing and HVAC Part 3 #10205

Space Sizing and HVAC Part 3 #10205

mjwitte commented Sep 6, 2023 •

edited

Loading

Myoldmopar commented Sep 12, 2023

mjwitte commented Sep 13, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

rraustad commented Sep 20, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

rraustad Sep 20, 2023

rraustad Sep 20, 2023

mjwitte Sep 20, 2023

mjwitte Sep 20, 2023

rraustad Sep 20, 2023

mjwitte Sep 20, 2023

rraustad Sep 20, 2023

rraustad Sep 20, 2023

mjwitte Sep 20, 2023

rraustad Sep 20, 2023

rraustad Sep 20, 2023

mjwitte Sep 20, 2023

rraustad commented Sep 20, 2023

rraustad Sep 20, 2023

mjwitte Sep 20, 2023

mjwitte commented Sep 20, 2023

Myoldmopar commented Sep 20, 2023

Myoldmopar commented Sep 20, 2023

Space Sizing and HVAC Part 3 #10205

Space Sizing and HVAC Part 3 #10205

Conversation

mjwitte commented Sep 6, 2023 • edited Loading

Pull request overview

ToDo

Pull Request Author

Reviewer

Myoldmopar commented Sep 12, 2023

mjwitte commented Sep 13, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

Diffs

rraustad commented Sep 20, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

mjwitte commented Sep 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Sep 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Sep 20, 2023

Myoldmopar commented Sep 20, 2023

Myoldmopar commented Sep 20, 2023

mjwitte commented Sep 6, 2023 •

edited

Loading