Skip to content

NewFeature: Add measurement unit output for API #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

Myoldmopar
Copy link
Member

Pull request overview

This is just a recreation of #10367, but with additional commits to get it ready for merging.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Myoldmopar Myoldmopar added NewFeature Includes code to add a new feature to EnergyPlus APIChange Code changes impact the Python Plugins, C API or Python API Bindings labels Jul 12, 2024
@Myoldmopar Myoldmopar added this to the EnergyPlus 24.2 IOFreeze milestone Jul 12, 2024
@Myoldmopar Myoldmopar self-assigned this Jul 12, 2024
@Myoldmopar
Copy link
Member Author

Mac is happy, Windows looks to be an unrelated failure (hopefully) so I restarted it, and we'll see what Linux says. If it's happy after all that, this will merge.

@Myoldmopar
Copy link
Member Author

Still happy with a quick pull from develop, merging this.

@Myoldmopar Myoldmopar merged commit 15f6491 into develop Jul 12, 2024
18 checks passed
@Myoldmopar Myoldmopar deleted the sghvaic_develop branch July 12, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIChange Code changes impact the Python Plugins, C API or Python API Bindings NewFeature Includes code to add a new feature to EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants