Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Input Field Description in Component Sizing Information for Multi-Speed DX Heating Coils #10612

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Correct Input Field Description in Component Sizing Information for Multi-Speed DX Heating Coils #10612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d7be48
Fixed numeric field names used for reporting
Nigusse Jul 14, 2024
b315fd2
Modified unit tests failed due to the fix
Nigusse Jul 19, 2024
00e1839
Merge branch 'develop' into multispeed_dx_htg_coil_reporting
Nigusse Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/EnergyPlus/DXCoils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8290,7 +8290,7 @@ void SizeDXCoil(EnergyPlusData &state, int const DXCoilNum)
CompType = thisDXCoil.DXCoilType;
// Sizing rated air flow rate
if (Mode == thisDXCoil.NumOfSpeeds) {
FieldNum = 12 + (Mode - 1) * 5;
FieldNum = 12 + (Mode - 1) * 6;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected indices to Field Names of multi-speed DX Heating Coils.

SizingString = state.dataDXCoils->DXCoilNumericFields(DXCoilNum).PerfMode(1).FieldNames(FieldNum) + " [m3/s]";
TempSize = thisDXCoil.MSRatedAirVolFlowRate(Mode);
state.dataSize->DataEMSOverrideON = thisDXCoil.RatedAirVolFlowRateEMSOverrideON(Mode);
Expand All @@ -8313,7 +8313,7 @@ void SizeDXCoil(EnergyPlusData &state, int const DXCoilNum)
bPRINT = true;
}
} else {
FieldNum = 12 + (Mode - 1) * 5;
FieldNum = 12 + (Mode - 1) * 6;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

SizingString = state.dataDXCoils->DXCoilNumericFields(DXCoilNum).PerfMode(1).FieldNames(FieldNum) + " [m3/s]";
if (IsAutoSize || !HardSizeNoDesRun) {
SizingMethod = HVAC::AutoCalculateSizing;
Expand Down Expand Up @@ -8407,7 +8407,7 @@ void SizeDXCoil(EnergyPlusData &state, int const DXCoilNum)
if (Mode == thisDXCoil.NumOfSpeeds) {
SizingMethod = HVAC::HeatingCapacitySizing;
state.dataSize->DataFlowUsedForSizing = thisDXCoil.MSRatedAirVolFlowRate(Mode);
FieldNum = 10 + (Mode - 1) * 5;
FieldNum = 10 + (Mode - 1) * 6;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

SizingString = state.dataDXCoils->DXCoilNumericFields(DXCoilNum).PerfMode(1).FieldNames(FieldNum) + " [W]";
state.dataSize->DataTotCapCurveIndex = thisDXCoil.MSCCapFTemp(Mode);
if (IsAutoSize || !HardSizeNoDesRun) {
Expand Down Expand Up @@ -8448,7 +8448,7 @@ void SizeDXCoil(EnergyPlusData &state, int const DXCoilNum)
} else {
PrintFlag = true;
SizingMethod = HVAC::HeatingCapacitySizing;
FieldNum = 10 + (Mode - 1) * 5;
FieldNum = 10 + (Mode - 1) * 6;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

SizingString = state.dataDXCoils->DXCoilNumericFields(DXCoilNum).PerfMode(1).FieldNames(FieldNum) + " [W]";
if (IsAutoSize || !HardSizeNoDesRun) {
SizingMethod = HVAC::AutoCalculateSizing;
Expand Down
6 changes: 3 additions & 3 deletions tst/EnergyPlus/unit/DXCoils.unit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ TEST_F(EnergyPlusFixture, DXCoils_Test1)

state->dataDXCoils->DXCoilNumericFields.allocate(state->dataDXCoils->NumDXCoils);
state->dataDXCoils->DXCoilNumericFields(2).PerfMode.allocate(1);
state->dataDXCoils->DXCoilNumericFields(2).PerfMode(1).FieldNames.allocate(17);
state->dataDXCoils->DXCoilNumericFields(2).PerfMode(1).FieldNames.allocate(18);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified array size allocation.

state->dataDXCoils->DXCoil(2).DefrostStrategy = StandardRatings::DefrostStrat::Resistive;
state->dataDXCoils->DXCoil(2).DefrostCapacity = 5000.0;
state->dataDXCoils->DXCoil(2).Name = "DX Heating coil";
Expand Down Expand Up @@ -4648,9 +4648,9 @@ TEST_F(EnergyPlusFixture, TestMultiSpeedCoilsAutoSizingOutput)
EXPECT_NEAR(16365.95, state->dataDXCoils->DXCoil(2).MSRatedTotCap(1), 0.01);
// Check EIO reporting
const std::string htg_coil_eio_output =
R"EIO( Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Speed 2 Gross Rated Heating COP [m3/s], 1.75000
R"EIO( Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Speed 2 Rated Air Flow Rate [m3/s], 1.75000
Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Speed 1 Rated Air Flow Rate [m3/s], 0.87500
Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Speed 1 Rated Waste Heat Fraction of Power Input [W], 32731.91226
Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Speed 2 Gross Rated Heating Capacity [W], 32731.91226
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the text to match the correct input field description in the eio output file.

Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Speed 1 Gross Rated Heating Capacity [W], 16365.95613
Component Sizing Information, Coil:Heating:DX:MultiSpeed, ASHP HTG COIL, Design Size Resistive Defrost Heater Capacity, 0.00000
! <DX Heating Coil Standard Rating Information>, Component Type, Component Name, High Temperature Heating (net) Rating Capacity {W}, Low Temperature Heating (net) Rating Capacity {W}, HSPF {Btu/W-h}, Region Number
Expand Down
Loading