Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CppCheck ZoneTempPredCorr #10698

Merged
merged 20 commits into from
Sep 11, 2024
Merged

CppCheck ZoneTempPredCorr #10698

merged 20 commits into from
Sep 11, 2024

Conversation

rraustad
Copy link
Contributor

Pull request overview

  • Fixes programming issues
  • Use CppCheck as guide

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Aug 27, 2024
amirroth
amirroth reviewed Aug 28, 2024
View reviewed changes
src/EnergyPlus/ZoneTempPredictorCorrector.cc
@@ -335,7 +331,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state)
auto &ComfortTStatObjects = state.dataZoneCtrls->ComfortTStatObjects;
auto &ComfortControlledZone = state.dataZoneCtrls->ComfortControlledZone;
int NumOfZones = state.dataGlobal->NumOfZones;
auto &StageControlledZone = state.dataZoneCtrls->StageControlledZone;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why eliminate this bad array shortcut and not the other ones around it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this change eliminated a CppCheck style suggestion and reducing these takes time and risks diffs when a mistake is made. These are the types of changes that will occur after reducing the number of suggestions to a manageable level.

amirroth
amirroth reviewed Aug 28, 2024
View reviewed changes
src/EnergyPlus/ZoneTempPredictorCorrector.cc
@@ -2788,10 +2761,6 @@ void InitZoneAirSetPoints(EnergyPlusData &state)
static constexpr std::string_view RoutineName("InitZoneAirSetpoints: ");

// SUBROUTINE LOCAL VARIABLE DECLARATIONS:
bool FirstSurfFlag;
int TRefFlag; // Flag for Reference Temperature process in Zones

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why eliminate this bad array reference shortcut and not the others?

amirroth
amirroth reviewed Aug 28, 2024
View reviewed changes
src/EnergyPlus/ZoneTempPredictorCorrector.cc Outdated
@@ -3969,14 +3935,14 @@ void ZoneSpaceHeatBalanceData::calcPredictedHumidityRatio(EnergyPlusData &state,

if (offsetThermostat != 0.0) {
// Calculate the humidistat offset value from the thermostat offset value
faultZoneWHumidifyingSetPoint = Psychrometrics::PsyWFnTdbRhPb(
double faultZoneWHumidifyingSetPoint = Psychrometrics::PsyWFnTdbRhPb(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Real64 instead of double.

@Myoldmopar
Copy link
Member

And again, all happy locally. Merging this as well. Thanks @rraustad

@Myoldmopar Myoldmopar merged commit 4c8d4b4 into develop Sep 11, 2024
10 checks passed
@Myoldmopar Myoldmopar deleted the CppCheck-ZoneTempPredCorr branch September 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirroth amirroth amirroth left review comments

Assignees
No one assigned
Labels
DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rraustad @Myoldmopar @amirroth @nrel-bot @nrel-bot-2 @nrel-bot-2b @nrel-bot-2c