Fix wshp array bounds error and sizing #10735
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2580,86 +2580,92 @@ namespace WaterToAirHeatPumpSimple { | |
|
|
||
| // determine adjusted cooling and heating coil capacity | ||
| simpleWatertoAirHP.RatedCapHeatAtRatedCdts = RatedCapHeatDes * RatedHeatCapTempModFac; | ||
|
There was a problem hiding this comment. I believe what the code below is trying to do is to size a HP, so the coils would need to be the same size. In this case that's not necessary but an actual HP would need to be tested to make sure it works. I guess it does work since all WSHPs apparently size correctly, or do they? |
||
| if (simpleWatertoAirHP.CompanionCoolingCoilNum > 0) { | ||
| auto &companionCoolingCoil(state.dataWaterToAirHeatPumpSimple->SimpleWatertoAirHP(simpleWatertoAirHP.CompanionCoolingCoilNum)); | ||
| if (companionCoolingCoil.WAHPPlantType == DataPlant::PlantEquipmentType::CoilWAHPCoolingEquationFit && | ||
| companionCoolingCoil.RatedCapCoolTotal == DataSizing::AutoSize) { | ||
| // case 1: companion coil is also of EquationFit type and is being autosized | ||
| RatedCapCoolTotalDes = state.dataSize->DXCoolCap; | ||
| RatedTotCapTempModFac = companionCoolingCoil.RatedCapCoolAtRatedCdts / RatedCapCoolTotalDes; | ||
| RatedCapCoolHeatDD = | ||
| simpleWatertoAirHP.RatedCapHeatAtRatedCdts / simpleWatertoAirHP.RatioRatedHeatRatedTotCoolCap / RatedTotCapTempModFac; | ||
| RatedCoolPowerTempModFac = companionCoolingCoil.RatedPowerCoolAtRatedCdts / companionCoolingCoil.RatedPowerCool; | ||
| if (RatedCapCoolHeatDD > RatedCapCoolTotalDes) { | ||
| // total cooling capacity | ||
| RatedCapCoolTotalDes = RatedCapCoolHeatDD; | ||
| // adjust for system air flow -- capacity is based on heating design day calcs | ||
| // adjust by ratio of system to heating air flow rate and temperature delta across the coil at these different airflow | ||
| if (HeatingAirVolFlowRateDes > 0) { | ||
| RatedCapCoolTotalDes *= (RatedAirVolFlowRateDes / HeatingAirVolFlowRateDes) * HeatdTratio; | ||
| } | ||
| // calculate ajustment factor over previous capacity for sensible capacity adjustment | ||
| Real64 CapCoolAdjFac = RatedCapCoolTotalDes / state.dataSize->DXCoolCap; | ||
| // update cooling coil rated capacity after adjustments based on heating coil size | ||
| state.dataSize->DXCoolCap = RatedCapCoolTotalDes; | ||
| // sensible cooling capacity | ||
| RatedCapCoolSensDes = companionCoolingCoil.RatedCapCoolSens * CapCoolAdjFac; // Assume that SHR stays the same | ||
| companionCoolingCoil.RatedCapCoolSensDesAtRatedCdts *= CapCoolAdjFac; | ||
| companionCoolingCoil.RatedCapCoolSens = RatedCapCoolSensDes; | ||
| // update Water-to-Air Heat Pumps output reports | ||
| OutputReportPredefined::PreDefTableEntry(state, | ||
| state.dataOutRptPredefined->pdchWAHPRatedSensCapAtRatedCdts, | ||
| companionCoolingCoil.Name, | ||
| companionCoolingCoil.RatedCapCoolSensDesAtRatedCdts); | ||
| OutputReportPredefined::PreDefTableEntry( | ||
| state, state.dataOutRptPredefined->pdchWAHPDD, companionCoolingCoil.Name, "Heating"); | ||
| OutputReportPredefined::PreDefTableEntry( | ||
| state, state.dataOutRptPredefined->pdchWAHPDD, simpleWatertoAirHP.Name, "Heating"); | ||
| // update Cooling Coils output reports | ||
| OutputReportPredefined::PreDefTableEntry(state, | ||
| state.dataOutRptPredefined->pdchCoolCoilLatCap, | ||
| companionCoolingCoil.Name, | ||
| RatedCapCoolTotalDes - RatedCapCoolSensDes); | ||
| OutputReportPredefined::PreDefTableEntry(state, | ||
| state.dataOutRptPredefined->pdchCoolCoilSHR, | ||
| companionCoolingCoil.Name, | ||
| RatedCapCoolSensDes / RatedCapCoolTotalDes); | ||
| OutputReportPredefined::PreDefTableEntry( | ||
| state, state.dataOutRptPredefined->pdchCoolCoilSensCap, companionCoolingCoil.Name, RatedCapCoolSensDes); | ||
| } else { | ||
| OutputReportPredefined::PreDefTableEntry( | ||
| state, state.dataOutRptPredefined->pdchWAHPDD, companionCoolingCoil.Name, "Cooling"); | ||
| OutputReportPredefined::PreDefTableEntry( | ||
| state, state.dataOutRptPredefined->pdchWAHPDD, simpleWatertoAirHP.Name, "Cooling"); | ||
| } | ||
| RatedCapHeatDes = | ||
| RatedCapCoolTotalDes * RatedTotCapTempModFac * simpleWatertoAirHP.RatioRatedHeatRatedTotCoolCap / RatedHeatCapTempModFac; | ||
| companionCoolingCoil.RatedCapCoolTotal = RatedCapCoolTotalDes; | ||
| companionCoolingCoil.RatedCapCoolAtRatedCdts = RatedCapCoolTotalDes * RatedTotCapTempModFac; | ||
| companionCoolingCoil.RatedPowerCoolAtRatedCdts = | ||
| companionCoolingCoil.RatedCapCoolAtRatedCdts / companionCoolingCoil.RatedCOPCoolAtRatedCdts; | ||
| companionCoolingCoil.RatedPowerCool = companionCoolingCoil.RatedPowerCoolAtRatedCdts / RatedCoolPowerTempModFac; | ||
| // update Water-to-Air Heat Pumps output reports | ||
| OutputReportPredefined::PreDefTableEntry(state, | ||
| state.dataOutRptPredefined->pdchWAHPRatedCapAtRatedCdts, | ||
| companionCoolingCoil.Name, | ||
| companionCoolingCoil.RatedCapCoolAtRatedCdts); | ||
| // update Cooling Coils output reports | ||
| OutputReportPredefined::PreDefTableEntry( | ||
| state, state.dataOutRptPredefined->pdchCoolCoilTotCap, companionCoolingCoil.Name, RatedCapCoolTotalDes); | ||
| BaseSizer::reportSizerOutput( | ||
| state, | ||
| format("COIL:{}:WATERTOAIRHEATPUMP:EQUATIONFIT", WatertoAirHPNamesUC[static_cast<int>(companionCoolingCoil.WAHPType)]), | ||
| companionCoolingCoil.Name, | ||
| "Design Size Rated Total Cooling Capacity [W]", | ||
| companionCoolingCoil.RatedCapCoolTotal); | ||
| BaseSizer::reportSizerOutput( | ||
| state, | ||
| format("COIL:{}:WATERTOAIRHEATPUMP:EQUATIONFIT", WatertoAirHPNamesUC[static_cast<int>(companionCoolingCoil.WAHPType)]), | ||
| companionCoolingCoil.Name, | ||
| "Design Size Rated Sensible Cooling Capacity [W]", | ||
| companionCoolingCoil.RatedCapCoolSens); | ||
| } else if (companionCoolingCoil.WAHPPlantType == | ||
| DataPlant::PlantEquipmentType::CoilWAHPCoolingEquationFit) { // case 2: companion coil is of EquationFit type but is | ||
| // not autosized | ||
| RatedCapHeatDes = companionCoolingCoil.RatedCapCoolTotal * simpleWatertoAirHP.RatioRatedHeatRatedTotCoolCap; | ||
| } else { // case 3: companion type is different than EquationFit | ||
| RatedCapHeatDes = state.dataSize->DXCoolCap; | ||
| } | ||
| } | ||
| // heating capacity final determination | ||
| simpleWatertoAirHP.RatedCapHeat = RatedCapHeatDes; | ||
|
|
@@ -2734,7 +2740,7 @@ namespace WaterToAirHeatPumpSimple { | |
|
|
||
| // user provided inputs are assumed to be at rated conditions | ||
| simpleWatertoAirHP.RatedPowerHeat = simpleWatertoAirHP.RatedCapHeat / simpleWatertoAirHP.RatedCOPHeatAtRatedCdts; | ||
| simpleWatertoAirHP.RatedCapHeatAtRatedCdts = simpleWatertoAirHP.RatedCapHeat; | ||
|
There was a problem hiding this comment. Why would the rated capacity sizing variable be set to 0 if not autosized? And what about rated power below? and check the cooling coil code. There was a problem hiding this comment. I guess I could have changed the water flow rate sizing to use RatedCapHeat instead. There was a problem hiding this comment. There is likely a difference between RatedCapHeat and RatedCapHeatAtRatedCdts given the CapFT term applied. This is above at line 2743. There was a problem hiding this comment. I think these equations need to be moved up into the IF blocks in order to use the correct variable. If RatedCapHeat is the coil load and RatedCapHeatatRatedCdts is the coil size, when autosized, then declaring these variables AFTER the coil size is determined seems wrong (i.e., after the if/else). If autosized, RatedCapHeatatRatedCdts should be used as the capacity, if not autosized, RatedCapHeat should be used as the capacity. There was a problem hiding this comment. I actually want to revert this change and change the RatedWaterVolFlowRateDes sizing equation to use RatedCapHeat because that's what the sizing routine is setting as the final coil capacity. And the calc routine uses RatedCapHeat as the coil capacity. So RatedCapHeat should be the final coil size whether the coil is autosized or hard-sized. So it follows that the water flow rate should use RatedHeatCap because that's the coil size. You can't see an issue in model performance when the water flow rate is sized with either of these variables because only exit water temp changes, not performance. You would have to really critique the exiting water temp to see an issue and even then it would be hard to see. And then I look at this line and it looks like RatedCapHeatAtRatedCdts is the correct variable to use to size the water flow rate. So I will leave this branch in this state for now even though I think it's wrong. There was a problem hiding this comment. RatedCapHeatDes is the CapFT modified coil capacity, as is RatedCapHeat. The next line modifies this value by the rated CapFT, which should be 1 by definition (but I expect it's not 1). So now I'm back to using RatedCapHeat to size the water flow rate. This is so very confusing but I think I am more comfortable with this now. @mjwitte ? simpleWatertoAirHP.RatedCapHeatAtRatedCdts = RatedCapHeatDes * RatedHeatCapTempModFac; |
||
| simpleWatertoAirHP.RatedPowerHeatAtRatedCdts = 0; | ||
| } | ||
| // Check that heat pump heating capacity is within 20% of cooling capacity. Check only for heating coil and report both. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wrapped all this in 1 IF block. Still not sure if the code at the end of this block is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next step is to remove this IF block. There is no reason to call the cooling coil to report the UnitarySystem heating capacity. That's a cover up.