Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a problem matcher for gcc warnings/errors: for develop commits, and branch of PR #10832

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Add a problem matcher for gcc warnings/errors: for develop commits, and branch of PR #10832

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c62af83
Add a problem matcher for gcc warnings/errors: for develop commits, a…
jmarrec Nov 25, 2024
56150e3
Apply suggestions from code review
jmarrec Nov 25, 2024
ca00ccc
Add upterm [decent_ci_skip]
Myoldmopar Nov 25, 2024
178b0ca
Try to find matcher in .. [decent_ci_skip]
Myoldmopar Nov 25, 2024
fc5f8ac
Add matcher doesnt seem to respect working dir spec [decent_ci_skip]
Myoldmopar Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/cpp-problem-matcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"problemMatcher": [
{
"owner": "gcc-problem-matcher",
"pattern": [
{
"regexp": "^(.*?):(\\d+):(\\d*):?\\s+(?:fatal\\s+)?(warning|error):\\s+(.*)$",
"file": 1,
"line": 2,
"column": 3,
"severity": 4,
"message": 5
}
]
}
]
}
Comment on lines +1 to +17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf https://regex101.com/r/4mPjR3/1 for demo

5 changes: 4 additions & 1 deletion .github/workflows/test_develop_commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,10 @@ jobs:
- name: Build
id: build
working-directory: ./build
run: cmake --build . -j ${{ matrix.nproc }} --config Release
run: |
echo "::add-matcher::.github/workflows/cpp-problem-matcher.json"
jmarrec marked this conversation as resolved.
Show resolved Hide resolved
cmake --build . -j ${{ matrix.nproc }} --config Release
echo "::remove-matcher owner=gcc-problem-matcher::"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building develop commits, we add it, build, and remove it.


- name: Test
# Not running test on alternate build yet, I need to test things
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test_pull_requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,10 @@ jobs:
- name: Branch Build
id: branch_build
working-directory: ./branch/build
run: cmake --build . -j ${{ matrix.nproc }} --config Release
run: |
echo "::add-matcher::.github/workflows/cpp-problem-matcher.json"
jmarrec marked this conversation as resolved.
Show resolved Hide resolved
cmake --build . -j ${{ matrix.nproc }} --config Release
echo "::remove-matcher owner=gcc-problem-matcher::"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing PR: enable it only when building the PR branch (not develop for regression)


- name: Branch Test
working-directory: ./branch/build
Expand Down
Loading