Fan:SystemModel with discrete speed flow fractions crashes when speeds >= 2 #10846

rraustad · 2024-12-05T04:12:54Z

Pull request overview

Fixes EnergyPlus Crashes with Fan:SystemModel with Discrete speeds #10845
Fan:SystemModel with multispeed flow fractions crashes when speeds >= 2 because fan has not sized yet.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

rraustad · 2024-12-05T04:14:23Z

src/EnergyPlus/HVACVariableRefrigerantFlow.cc

-                                for (int i = 1; i <= vrfTU.NumOfSpeedCooling; ++i) {
-                                    vrfTU.CoolMassFlowRate[i] = fanSystem->massFlowAtSpeed[i - 1];
-                                }
-                            }


Crashes in these places in VRF GetInput because massFlowAtSpeed is allocated in the fan's set_size function and that has not been called yet.

rraustad · 2024-12-05T04:15:53Z

src/EnergyPlus/HVACVariableRefrigerantFlow.cc

+                                }
+                            }
+                        }
+                    }


So moved these initializations to Init where the code waits for the fan to size before setting up air flow variables.

rraustad · 2024-12-05T04:19:58Z

tst/EnergyPlus/unit/HVACVariableRefrigerantFlow.unit.cc

+    EXPECT_NEAR(state->dataHVACVarRefFlow->VRFTU[0].CycRatio, 0.713204045, 0.00001); // was 0.713222413
+}
+
+TEST_F(EnergyPlusFixture, VRF_MultispeedFan_Test_HardSized)


New unit test with hard-sized inputs for airflow, capacity and SHR that are duplicate of results from above unit test. These answers are a little different then when using autosize.

github-actions · 2024-12-05T05:08:51Z

⚠️ Regressions detected on macos-14 for commit `0fa62eb`

Regression Summary

EIO: 1
ERR: 1
ESO Big Diffs: 1
MTR Small Diffs: 1
Table Big Diffs: 1
Table String Diffs: 1

rraustad · 2024-12-05T13:14:20Z

A clue to the diffs on Mac CI for VRFMultispeedFan. TU2 fan is the only multispeed fan of the 5 TUs in this example file. No Cooling SA Flow Rate changed while No Heating SA Flow Rate did not. @Myoldmopar why is Mac CI picking up diffs while the other CIs do not?

- Component Sizing Information, ZoneHVAC:TerminalUnit:VariableRefrigerantFlow, TU2, Design Size No Cooling Supply Air Flow Rate [m3/s], 0.21531
+ Component Sizing Information, ZoneHVAC:TerminalUnit:VariableRefrigerantFlow, TU2, Design Size No Cooling Supply Air Flow Rate [m3/s], 0.00000
  Component Sizing Information, ZoneHVAC:TerminalUnit:VariableRefrigerantFlow, TU2, Design Size No Heating Supply Air Flow Rate [m3/s], 0.21531

mjwitte · 2024-12-05T17:49:04Z

A clue to the diffs on Mac CI for VRFMultispeedFan. TU2 fan is the only multispeed fan of the 5 TUs in this example file. No Cooling SA Flow Rate changed while No Heating SA Flow Rate did not. @Myoldmopar why is Mac CI picking up diffs while the other CIs do not?

Mac is the only one running regressions now.

rraustad · 2024-12-05T19:03:26Z

src/EnergyPlus/HVACVariableRefrigerantFlow.cc

@@ -7728,7 +7741,7 @@ void SizeVRF(EnergyPlusData &state, int const VRFTUNum)
                } else {
                    auto *fanSystem = dynamic_cast<Fans::FanSystem *>(state.dataFans->fans(state.dataHVACVarRefFlow->VRFTU(VRFTUNum).FanIndex));
                    assert(fanSystem != nullptr);
-                    if (state.dataHVACVarRefFlow->VRFTU(VRFTUNum).CoolMassFlowRate[i] == 0.0) {
+                    if (state.dataHVACVarRefFlow->VRFTU(VRFTUNum).CoolMassFlowRate[i] == 0.0 && !fanSystem->massFlowAtSpeed.empty()) {


Just in case the fan has not yet been sized.

Interesting. Is that something that actually could happen for a normal IDF run? Or is this just to proof it against missing inits in unit tests?

This was a normal idf run. The massFlowAtSpeed array is not allocated until Fan::set_size is called. Which may not have been called yet at this point in VRF sizing.

nrel-bot-2 · 2024-12-21T00:17:35Z

@rraustad it has been 15 days since this pull request was last updated.

nrel-bot-2 · 2024-12-28T00:21:26Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2025-01-04T00:43:14Z

@rraustad it has been 7 days since this pull request was last updated.

…45-VRF-crash-with-discrete-system-fan

Myoldmopar

This is fine as is. I'm curious about the empty checks, but they aren't causing trouble. I'll give this a quick check.

Myoldmopar · 2025-02-06T14:06:27Z

src/EnergyPlus/HVACVariableRefrigerantFlow.cc

@@ -7728,7 +7741,7 @@ void SizeVRF(EnergyPlusData &state, int const VRFTUNum)
                } else {
                    auto *fanSystem = dynamic_cast<Fans::FanSystem *>(state.dataFans->fans(state.dataHVACVarRefFlow->VRFTU(VRFTUNum).FanIndex));
                    assert(fanSystem != nullptr);
-                    if (state.dataHVACVarRefFlow->VRFTU(VRFTUNum).CoolMassFlowRate[i] == 0.0) {
+                    if (state.dataHVACVarRefFlow->VRFTU(VRFTUNum).CoolMassFlowRate[i] == 0.0 && !fanSystem->massFlowAtSpeed.empty()) {


Interesting. Is that something that actually could happen for a normal IDF run? Or is this just to proof it against missing inits in unit tests?

Myoldmopar · 2025-02-06T14:07:04Z

src/EnergyPlus/HVACVariableRefrigerantFlow.cc

-                                for (int i = 1; i <= vrfTU.NumOfSpeedCooling; ++i) {
-                                    vrfTU.CoolMassFlowRate[i] = fanSystem->massFlowAtSpeed[i - 1];
-                                }
-                            }


Myoldmopar · 2025-02-06T14:25:02Z

Good to go, thanks @rraustad !

Fix crash with Fan SystemModel discrete speeds

567d1d5

rraustad added the Defect Includes code to repair a defect in EnergyPlus label Dec 5, 2024

rraustad commented Dec 5, 2024

View reviewed changes

rraustad changed the title ~~Fan:SystemModel with discrete speed flow fractions crashes for speeds > 2~~ Fan:SystemModel with discrete speed flow fractions crashes when speeds >= 2 Dec 5, 2024

Update to address diffs

c96ab29

rraustad commented Dec 5, 2024

View reviewed changes

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 108…

90ecbb5

…45-VRF-crash-with-discrete-system-fan

Myoldmopar approved these changes Feb 6, 2025

View reviewed changes

Myoldmopar merged commit 28140c5 into develop Feb 6, 2025
9 checks passed

Myoldmopar deleted the 10845-VRF-crash-with-discrete-system-fan branch February 6, 2025 14:25

Fan:SystemModel with discrete speed flow fractions crashes when speeds >= 2 #10846

Fan:SystemModel with discrete speed flow fractions crashes when speeds >= 2 #10846

Uh oh!

Conversation

rraustad commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Reviewer

Uh oh!

rraustad Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Myoldmopar Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

rraustad Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rraustad Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 5, 2024

⚠️ Regressions detected on macos-14 for commit 0fa62eb

Uh oh!

rraustad commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjwitte commented Dec 5, 2024

Uh oh!

rraustad Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

Myoldmopar Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

rraustad Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nrel-bot-2 commented Dec 21, 2024

Uh oh!

nrel-bot-2 commented Dec 28, 2024

Uh oh!

nrel-bot-2 commented Jan 4, 2025

Uh oh!

Myoldmopar left a comment

Choose a reason for hiding this comment

Uh oh!

Myoldmopar Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

Myoldmopar Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

Myoldmopar commented Feb 6, 2025

Uh oh!

Uh oh!

Uh oh!

rraustad commented Dec 5, 2024 •

edited

Loading

rraustad Dec 5, 2024 •

edited

Loading

rraustad Dec 5, 2024 •

edited

Loading

rraustad Dec 5, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `0fa62eb`

rraustad commented Dec 5, 2024 •

edited

Loading

rraustad Feb 6, 2025 •

edited

Loading