CppCheck exp and log

[rraustad]

Pull request overview

• Fixes CppCheck style suggestions
• Use CppCheck as guide

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[github-actions]

⚠️ Regressions detected on macos-14 for commit 7949c40

Regression Summary

• ESO Small Diffs: 248
• EIO: 197
• MTR Small Diffs: 205
• Table Small Diffs: 138
• Table String Diffs: 27
• JSON Small Diffs: 2
• Table Big Diffs: 11
• EDD: 2
• ERR: 7
• MTR Big Diffs: 1
• ESO Big Diffs: 5

• View Results
• Download Regressions

[rraustad]

@Myoldmopar neither of these files (OutdoorAirUnit and OutdoorAirUnitwithAirloopHVAC) fail locally on Windows. Can you tell me what the failure is on Linux or Mac?

[github-actions]

⚠️ Regressions detected on macos-14 for commit afa526b

Regression Summary

• ESO Small Diffs: 250
• EIO: 198
• MTR Small Diffs: 207
• Table Small Diffs: 139
• Table String Diffs: 27
• JSON Small Diffs: 2
• Table Big Diffs: 11
• EDD: 2
• ERR: 7
• MTR Big Diffs: 1
• ESO Big Diffs: 5

• View Results
• Download Regressions

[rraustad]

Closing this branch since there are too many big diffs. Will do these math changes individually.