Add Max Compressor OAT field for Coil:Cooling:DX object

[shorowit]

Pull request overview

• Adds a new field to specify a maximum outdoor drybulb temperature for compressor operation.
• No point adding it to other DX cooling coil objects because they are being deprecated, right?

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[shorowit]

@rraustad @Myoldmopar I added a new "Maximum Outdoor Dry-Bulb Temperature for Compressor Operation" field and followed the pattern for the "Minimum Outdoor Dry-Bulb Temperature for Compressor Operation" field, only to find out that it does nothing. I discovered that the logic was only ever implemented for setpoint control, not load control, see here. How much effort is it to support this?

[github-actions]

⚠️ Regressions detected on macos-14 for commit 71af329

Regression Summary

• Table Small Diffs: 4
• Table Big Diffs: 16

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit 5b9f404

Regression Summary

• Table Small Diffs: 4
• Table Big Diffs: 16

• View Results
• Download Regressions

[mjwitte]

@rraustad @Myoldmopar I added a new "Maximum Outdoor Dry-Bulb Temperature for Compressor Operation" field and followed the pattern for the "Minimum Outdoor Dry-Bulb Temperature for Compressor Operation" field, only to find out that it does nothing. I discovered that the logic was only ever implemented for setpoint control, not load control, see here. How much effort is it to support this?

Hmmm, looks like Furnaces.cc checks this, unitary checks it for multispeed DX, the legacy coils all check it at their level. So, it should be straightforward to add a check somewhere in the new DX coil at the same place the availability schedule is checked. But it looks like that's not checked either. @shorowit Please post a new issue for this.