#10923 - Quick fix Epl-run.bat

[jmarrec]

Pull request overview

• Partially fixes the issue Space sizing files not saved by EP-Launch #10923 (it DOES not add a button to EP-Launch)

Description of the purpose of this PR

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

@jmarrec do you want @JasonGlazer to build a new EP-Launch (VB6) version for this?

And do we need to modify EP-Launch-3 (Python) to handle this also? If so, this is probably something in the workflows/ here in this repo, unless it's a GUI change.

[jmarrec]

I'm just doing a drive-thru fix here. Instead of letting it drag along, at least even without a button to open it up, it will be present in the run directory instead of plain missing. Took me 5min. This is not part of a defect ticket.

And yes, someone else should handle the vb6 side, I don't have a compiler handy

[Myoldmopar]

This is fine as is. We should consider adding to EP Launch and the workflow file for EP Launch 3, but this doesn't need to hold that up. @mjwitte or @JasonGlazer if you want to test this, that's great. If not, this can merge in and we can follow up with the other fixes.

[Myoldmopar]

Meh, let's go ahead and get this in. Follow-up to come with updates to workflows, EP Launch GUI, whatever else is needed.

[JasonGlazer]

@jmarrec I think some lines that look like the following should probably be added around line 415 of EPL-run.bat

IF EXIST "%epout%Spsz.csv" DEL "%epout%Spsz.csv"
IF EXIST "%epout%Spsz.tab" DEL "%epout%Spsz.tab"
IF EXIST "%epout%Spsz.txt" DEL "%epout%Spsz.txt"

This deletes them just in case the user has changed the format of that output.