1st pass on using air distribution effectiveness in OA calculation #9678

rraustad · 2022-09-28T21:04:26Z

Pull request overview

Fixes AirTerminal:SingleDuct:Mixer does not account for DesignSpecification:ZoneAirDistribution #9677
Terminal unit outdoor air quantity did not account for zone air distribution effectiveness

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

ToDo:

Modify at least 1 example file to use air distribution effectiveness < 1
Docs to explain the use of cooling and heating AD effectiveness with respect to TUs and ATMixers
Report ATMixer primary flow sizing to eio?

rraustad · 2022-09-28T21:05:56Z

src/EnergyPlus/SingleDuct.cc

@@ -6355,7 +6360,7 @@ void AirTerminalMixerData::InitATMixer(EnergyPlusData &state, bool const FirstHV
            airLoopOAFrac = state.dataAirLoop->AirLoopFlow(this->AirLoopNum).OAFrac;
            if (airLoopOAFrac > 0.0) {
                vDotOAReq = DataSizing::calcDesignSpecificationOutdoorAir(state, this->OARequirementsPtr, this->ZoneNum, UseOccSchFlag, true);
-                mDotFromOARequirement = vDotOAReq * state.dataEnvrn->StdRhoAir / airLoopOAFrac;
+                mDotFromOARequirement = vDotOAReq * state.dataEnvrn->StdRhoAir / (airLoopOAFrac * this->ADEff);


What should be done here is include ADEff inside calcDesignSpecificationOutdoorAir so other models will also get this update

This was the change needed to see differences in the simulation results. Without this change there are only diffs in the eio.

I don't know the best solution, but I don't think we want to be mixing extra functionality into DesignSpecification:OutdoorAir. The issue here is that some of the info is in DesignSpecification:OutdoorAir and some is in DesignSpecification:ZoneAirDistribution. I think these sorts of complexities should be handled at the parent level and these design spec object models should be kept simple, just the dry results please, and let the parents do what they need with the specification.

The ATMixer receives OA from the system. There is no adjustment at the ATMixer. So maybe the system (DOAS) is not providing the correct amount of OA. I'm still looking at that. It appears the TUs do need this adjustment and I will look at that after I figure out if the ATMixer really has an issue.

rraustad · 2022-09-28T21:07:21Z

I get the change I expect to the eio but without the change to adjust OA during the simulation there are no diffs. I think this change needs to be generic and this branch is not there yet.

rraustad · 2022-09-28T21:10:22Z

The first question is should the zone OA quantity be adjusted by zone air distribution effectiveness. I believe the answer is yes but no model is currently doing this. The issue description shows that MinOA is getting adjusted during sizing which makes sense. But without also adjusting the OA quantity during the simulation the zone ADEff is not accounted for.

rraustad · 2022-09-28T21:21:06Z

src/EnergyPlus/SingleDuct.cc

+                                std::min(state.dataSize->ZoneSizingInput(SizingInputNum).ZoneADEffCooling,
+                                         state.dataSize->ZoneSizingInput(SizingInputNum).ZoneADEffHeating);
+                            state.dataSingleDuct->SysATMixer(ATMixerNum).DesignPrimaryAirVolRate /=
+                                state.dataSingleDuct->SysATMixer(ATMixerNum).ADEff;


This is a one time init in GetATMixers that adjusts the ATMixer primary flow based on zone distribution effectiveness. This is all good except without also adjusting the zone OA calculated during the simulation this one time init only affects the size, not the operating flow rate.

rraustad · 2022-09-28T21:31:28Z

src/EnergyPlus/SingleDuct.hh

@@ -323,6 +323,7 @@ namespace SingleDuct {
        Real64 DesignPrimaryAirVolRate;                           // System sizing adjustments, filled from design OA spec using sizing mode flags.
        DataZoneEquipment::PerPersonVentRateMode OAPerPersonMode; // mode for how per person rates are determined, DCV or design.
        bool printWarning;                                        // flag to print warnings only once
+        Real64 ADEff = 1.0;


I am questioning where this saved data should live. The DesignSpecification:ZoneAirDistribution object name can be entered in the Sizing:Zone object. This object name can also be entered in Controller:MechanicalVentilation. So somewhere this data needs to be saved. Also, there is an effectiveness for both cooling and heating, so using the min of these to determine OA seems wrong. If cooling eff=1 and heating eff=0.8 then OA during heating and cooling should be different.

rraustad · 2022-09-28T23:38:35Z

Interesting, no diffs. What I see in every unit test is this. Same for example files?

    "  DesignSpecification:ZoneAirDistribution,",
    "    SZ DSOA EAST ZONE Design Spec Zone Air Dist,  !- Name",
    "    1,                       !- Zone Air Distribution Effectiveness in Cooling Mode {dimensionless}",
    "    1;                       !- Zone Air Distribution Effectiveness in Heating Mode {dimensionless}",

rraustad · 2022-10-13T16:30:17Z

The first change (lines 6278 - 6282) adjusts the ATMixer DesignPrimaryAirVolRate to match what is reported in the eio. These design flow rates for the ATMixer are not reported to the eio so this was never noticed.

0.1298 + 0.059 + 0.1298 + 0.059 + 0.236 = 0.6136.

The second change (line 6363) adjusts the ATMixer's raw OA to include air distribution effectivenss and provides the correct flow rates as seen in this figure. This is all in the parent object so things look good so far. Now on to the TUs.

nrel-bot-3 · 2022-11-12T00:18:41Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-3 · 2022-12-10T00:33:08Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-3 · 2023-01-07T00:19:44Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2023-02-04T00:22:37Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

Myoldmopar · 2023-02-23T14:19:55Z

@rraustad how are you feeling about this branch? It's draft, which is fine, I just want to attach a milestone to it if you intend on getting it moving forward sometime.

nrel-bot · 2023-03-24T00:13:28Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2c · 2023-04-21T00:20:09Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2c · 2023-04-29T00:22:15Z

@rraustad it has been 8 days since this pull request was last updated.

nrel-bot-2 · 2023-05-06T00:15:28Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2b · 2023-05-13T00:30:25Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c · 2023-05-20T00:08:20Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2023-05-20T00:17:10Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2b · 2023-05-27T00:09:06Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2023-06-03T00:07:52Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c · 2023-06-10T00:11:34Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2b · 2023-06-17T01:18:59Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2023-06-26T00:12:48Z

@rraustad it has been 9 days since this pull request was last updated.

nrel-bot-2c · 2023-07-03T00:09:39Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2b · 2023-07-10T00:10:21Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2b · 2023-09-29T00:29:45Z

@rraustad it has been 9 days since this pull request was last updated.

nrel-bot-2c · 2023-10-06T00:08:43Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2023-10-14T00:08:10Z

@rraustad it has been 8 days since this pull request was last updated.

…7-ADEff-issue-with-TUs

nrel-bot-2 · 2023-11-11T00:08:44Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2023-12-09T00:07:08Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-01-06T00:17:28Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

rraustad · 2024-02-02T05:10:56Z

@Myoldmopar @mjwitte I need some help with these steps to move this foward.

Move CalcOAMassFlow from a member of DualDuct and SingleDuct to be inherited by each
Actually use the cooling and heating air distribution effectiveness as an adjustment to OA quantity (instead of the min used now during design) in the call to where zone OA is calculated. That would either be calcDesignSpecificationOutdoorAir or CalcOAMassFlow. These examples seem correct for what each does but does not actually apply a heating and cooling eff during the simulation. These examples only adjust design data and what needs to happen is an adjustment during the simulation.
```
 // save Voz for predefined outdoor air summary report
 Real64 MinEz = std::min(finalZoneSizing.ZoneADEffCooling, finalZoneSizing.ZoneADEffHeating);

 if (finalZoneSizing.ZoneADEffCooling > 0.0 || finalZoneSizing.ZoneADEffHeating > 0.0) {
     finalZoneSizing.MinOA /= min(finalZoneSizing.ZoneADEffCooling, finalZoneSizing.ZoneADEffHeating);
     calcFinalZoneSizing.MinOA = finalZoneSizing.MinOA;
 }
```
Figure out a way to apply either the cooling or heating effectiveness to the calculation of OA mass flow for TUs (i.e., how do I know if the TU is in cooling or heating mode?). Tsupply versus Tzone should dictate the buoyancy? except I don't know that until the end of the TU calcs of the reheat coil, if present. QZnReq? wait for next iteration to know if system or zone coils are active?

    DesignSpecification:ZoneAirDistribution,
      \min-fields 1
      \memo This object is used to describe zone air distribution in terms of air distribution
      \memo effectiveness and secondary recirculation fraction. It is referenced by Sizing:Zone
      \memo and Controller:MechanicalVentilation objects
       A1,  \field Name
        \required-field
        \type alpha
        \reference DesignSpecificationZoneAirDistributionNames
       N1,  \field Zone Air Distribution Effectiveness in Cooling Mode
        \type real
        \default 1.0
        \minimum> 0.0
        \units dimensionless
       N2,  \field Zone Air Distribution Effectiveness in Heating Mode
        \type real
        \default 1.0
        \minimum> 0.0
        \units dimensionless
       A2,  \field Zone Air Distribution Effectiveness Schedule Name
        \type object-list
        \object-list ScheduleNames
        \note optionally used to replace Zone Air Distribution Effectiveness in Cooling and
        \note Heating Mode
       N3,  \field Zone Secondary Recirculation Fraction
        \type real
        \default 0.0
        \minimum 0.0
        \units dimensionless
       N4;  \field Minimum Zone Ventilation Efficiency
        \type real
        \default 0.0
        \minimum 0.0
        \maximum 1.0
        \units dimensionless

mjwitte · 2024-02-06T18:22:34Z

Some thoughts:
0. Grabbing the ADEff* from the sizing struct is fine - if there is one, but will it be there is there's no HVAC Sizing active? Since "Design Specification Outdoor Air Object Name" in terminal units can be different from the one used in Sizing:Zone, would it be better to add a new field to the terminal unit for "Design Specification Zone Air Distribution Object Name".

Would it make sense to have the various terminal units to inherit the air distribution unit, DataDefineEquip::ZoneAirEquip and put the calcOA function there? And that could make the effectiveness adjustment, and possibly make a duct leakage adjustment?
nothing to add here
I would use whatever the governing load is that the terminal unit is trying to control to, QZoneReq or equivalent.

nrel-bot-2c · 2024-03-06T00:14:15Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-04-03T00:12:01Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-05-01T00:57:41Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-3 · 2024-05-29T00:16:31Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-06-26T00:52:41Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-07-24T00:10:46Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2c · 2024-07-24T00:15:38Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-08-21T00:16:10Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot · 2024-10-18T00:20:37Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 · 2024-11-15T00:18:00Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 · 2024-11-22T00:17:00Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c · 2024-11-29T00:19:15Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c · 2024-12-06T00:20:28Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c · 2024-12-13T00:17:23Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2024-12-21T00:17:47Z

@rraustad it has been 8 days since this pull request was last updated.

nrel-bot-2 · 2024-12-28T00:21:38Z

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 · 2025-01-04T00:43:27Z

@rraustad it has been 7 days since this pull request was last updated.

rraustad added the Defect Includes code to repair a defect in EnergyPlus label Sep 28, 2022

rraustad commented Sep 28, 2022

View reviewed changes

rraustad added 2 commits October 13, 2022 15:26

Temp location for ADEff for TUs

6c680b4

Include ADEff for SingleDuct TUs

0686106

rraustad marked this pull request as draft October 14, 2022 14:31

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 967…

a830236

…7-ADEff-issue-with-TUs

rraustad modified the milestones: EnergyPlus 24.1, EnergyPlus 24.2 Jan 31, 2024

rraustad modified the milestones: EnergyPlus 24.2, EnergyPlus 25.1 Sep 19, 2024

1st pass on using air distribution effectiveness in OA calculation #9678

Are you sure you want to change the base?

1st pass on using air distribution effectiveness in OA calculation #9678

Conversation

rraustad commented Sep 28, 2022 • edited Loading

Pull request overview

Pull Request Author

Reviewer

ToDo:

rraustad Sep 28, 2022

Choose a reason for hiding this comment

rraustad Sep 28, 2022

Choose a reason for hiding this comment

EnergyArchmage Oct 6, 2022

Choose a reason for hiding this comment

rraustad Oct 13, 2022

Choose a reason for hiding this comment

rraustad commented Sep 28, 2022 • edited Loading

rraustad commented Sep 28, 2022

rraustad Sep 28, 2022

Choose a reason for hiding this comment

rraustad Sep 28, 2022

Choose a reason for hiding this comment

rraustad commented Sep 28, 2022

rraustad commented Oct 13, 2022

nrel-bot-3 commented Nov 12, 2022

nrel-bot-3 commented Dec 10, 2022

nrel-bot-3 commented Jan 7, 2023

nrel-bot commented Feb 4, 2023

Myoldmopar commented Feb 23, 2023

nrel-bot commented Mar 24, 2023

nrel-bot-2c commented Apr 21, 2023

nrel-bot-2c commented Apr 29, 2023

nrel-bot-2 commented May 6, 2023

nrel-bot-2b commented May 13, 2023

nrel-bot-2c commented May 20, 2023

nrel-bot-2 commented May 20, 2023

nrel-bot-2b commented May 27, 2023

nrel-bot-2 commented Jun 3, 2023

nrel-bot-2c commented Jun 10, 2023

nrel-bot-2b commented Jun 17, 2023

nrel-bot-2 commented Jun 26, 2023

nrel-bot-2c commented Jul 3, 2023

nrel-bot-2b commented Jul 10, 2023

nrel-bot-2b commented Sep 29, 2023

nrel-bot-2c commented Oct 6, 2023

nrel-bot-2 commented Oct 14, 2023

nrel-bot-2 commented Nov 11, 2023

nrel-bot commented Dec 9, 2023

nrel-bot commented Jan 6, 2024

rraustad commented Feb 2, 2024 • edited Loading

mjwitte commented Feb 6, 2024

nrel-bot-2c commented Mar 6, 2024

nrel-bot commented Apr 3, 2024

nrel-bot commented May 1, 2024

nrel-bot-3 commented May 29, 2024

nrel-bot commented Jun 26, 2024

nrel-bot commented Jul 24, 2024

nrel-bot-2c commented Jul 24, 2024

nrel-bot commented Aug 21, 2024

nrel-bot commented Oct 18, 2024

nrel-bot-2 commented Nov 15, 2024

nrel-bot-2 commented Nov 22, 2024

nrel-bot-2c commented Nov 29, 2024

nrel-bot-2c commented Dec 6, 2024

nrel-bot-2c commented Dec 13, 2024

nrel-bot-2 commented Dec 21, 2024

nrel-bot-2 commented Dec 28, 2024

nrel-bot-2 commented Jan 4, 2025

rraustad commented Sep 28, 2022 •

edited

Loading

rraustad commented Sep 28, 2022 •

edited

Loading

rraustad commented Feb 2, 2024 •

edited

Loading