Support modeling vehicles for whole SFA/MF buildings #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
changed the base branch from
vehicles-whole-building
to
master
joseph-robertson
commented
Dec 5, 2025
| ev_discharge_program.addLine(" ElseIf #{temp_sensor.name} > #{UnitConversions.convert(100, 'F', 'C').round(3)}") | ||
| ev_discharge_program.addLine(" Set site_temp_adj = #{UnitConversions.convert(100, 'F', 'C').round(3)}") | ||
| ev_discharge_program.addLine(' EndIf') | ||
| ev_discharge_program.addLine(" Set power_mult = #{power_curve}") |
Collaborator
Author
There was a problem hiding this comment.
This line was previously before "Set site_temp_adj = ...", which I believe was a bug.
|
|
||
| hpxml_osm_map.each do |hpxml_bldg, unit_model| | ||
| unit_model.getElectricLoadCenterStorageLiIonNMCBatterys.each do |elcs| | ||
| vehicle = hpxml_bldg.vehicles[-1] # FIXME: is this right? |
Collaborator
Author
There was a problem hiding this comment.
We can have a max of 1 vehicle right?
Contributor
7 tasks
joseph-robertson
commented
Dec 5, 2025
Comment on lines
+69
to
+71
| if not discharging_schedule.nil? | ||
| eff_discharge_power = schedules_file.calc_design_level_from_daily_kwh(col_name: discharging_schedule.name.to_s, daily_kwh: ev_annl_energy / 365) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
It's possible that the schedules file does not include EV schedules.
joseph-robertson
commented
Dec 5, 2025
| base-vehicle-ev-charger.xml,82.721,82.721,45.452,45.452,37.268,0.0,0.0,0.0,0.0,0.0,0.0,1.16,0.0,0.0,3.58,0.797,10.883,0.0,0.0,4.507,0.142,0.334,0.0,0.0,0.0,0.0,1.802,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,8.151,37.268,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 | ||
| base-vehicle-ev-no-charger.xml,74.569,74.569,37.301,37.301,37.268,0.0,0.0,0.0,0.0,0.0,0.0,1.16,0.0,0.0,3.58,0.797,10.883,0.0,0.0,4.507,0.142,0.334,0.0,0.0,0.0,0.0,1.802,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,37.268,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 | ||
| base-vehicle-multiple.xml,82.768,82.768,45.5,45.5,37.268,0.0,0.0,0.0,0.0,0.0,0.0,1.16,0.0,0.0,3.58,0.797,10.883,0.0,0.0,4.507,0.142,0.334,0.0,0.0,0.0,0.0,1.802,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,8.199,37.268,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 | ||
| base-vehicle-multiple.xml,95.687,95.687,58.418,58.418,37.268,0.0,0.0,0.0,0.0,0.0,0.0,1.16,0.0,0.0,3.58,0.797,10.883,0.0,0.0,4.507,0.142,0.334,0.0,0.0,0.0,0.0,1.802,0.0,0.0,0.284,0.347,1.436,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,21.117,37.268,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0 |
Collaborator
Author
There was a problem hiding this comment.
This looks quite a bit different. Why?
…nd only select modeled vehicles to include in vehicle EMS program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
On second thought, couldn't we support whole SFA/MF buildings with vehicles since the TrackChargeDischargeSchedules storage operation scheme is always used?
Addresses #1499. This PR basically moves the EMS program from
vehicle.rbtooutput.rbso that it can be written after unit models are merged (similar to the unmet heating/cooling hours EMS program).Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run