Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop: Updating Test_Cases, FAST_Reader, and FAST_Writer to Accomodate OpenFAST v3.5.0 #245

Closed
wants to merge 9 commits into from
Closed

Develop: Updating Test_Cases, FAST_Reader, and FAST_Writer to Accomodate OpenFAST v3.5.0 #245

wants to merge 9 commits into from

Conversation

Yuksel-Rudy
Copy link
Contributor

@Yuksel-Rudy Yuksel-Rudy commented May 30, 2023 •
edited
Loading

Description and Purpose

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

@Yuksel-Rudy
Update NREL-2p8-127_InflowFile.dat
75054db 
added VelInterpCubic and LiDAR Parameters to the InflowFile
@Yuksel-Rudy
Update IEA-15-240-RWT_InflowFile.dat
d898709 
added VelInterpCubic and LiDAR Parameters to the InflowFile
@Yuksel-Rudy
Update NRELOffshrBsline5MW_InflowWind.dat
40729f7 
added VelInterpCubic and LiDAR Parameters to the InflowFile
@Yuksel-Rudy
Update NREL-2p8-127_InflowFile.dat
fa442dc 
added VelInterpCubic and LiDAR Parameters to the InflowFile
@Yuksel-Rudy
Update StC-Force-Col1.dat
3c6326b 
adjusted comment on StC_DOF_MODE
@Yuksel-Rudy
Update StC-Force-Col2.dat
f75f74c 
adjusted comment on StC_DOF_MODE
@Yuksel-Rudy
Update StC-Force-Col3.dat
7d89b79 
adjusted comment on StC_DOF_MODE
@Yuksel-Rudy
Update FAST_reader.py
ca9d0d6 
added parsing of cubic interpolation for velocity and LIDAR parameters in read_InflowWind method for the InflowWind data file
@Yuksel-Rudy
Update FAST_writer.py
2411b55 
added writing of cubic interpolation for velocity and LIDAR parameters in write_InflowWind method for the InflowWind data file
@Yuksel-Rudy
Copy link
Contributor Author

I have updated FAST_reader.py and FAST_writer.py but haven't tested them yet. Some LIDAR Parameters have long character width and I made sure they are written correctly but still needs to be checked.

Best regards,
Rudy

@Yuksel-Rudy Yuksel-Rudy changed the title Develop: Updating Test_Cases/InflowFile input files Develop: Updating Test_Cases, FAST_Reader, and FAST_Writer to Accomodate OpenFAST v3.5.0 May 30, 2023
@dzalkind dzalkind mentioned this pull request Jun 9, 2023
Merged
14 tasks
@dzalkind
Copy link
Collaborator

dzalkind commented Jun 9, 2023

Thanks for your contribution here, @Yuksel-Rudy! This PR has been merged with the other one in #246.

@dzalkind dzalkind closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuksel-Rudy @dzalkind