Fixed bug where TRA_LastRefSpd was set to a generator speed not the L… #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the correct fix, thanks! |
dzalkind
added a commit
that referenced
this pull request
Oct 11, 2024
* Update .readthedocs.yaml * Docs: Fix small bug in docs that caused errors with links * Start using automatic documentation for examples (#371) * Added autodocumentation template for all examples * Check for IPC openfast flag when using AWC * Fix GB and gen efficiencies GB efficiency reduces LSS to HSS GEN reduces HSS to generator electrical output We apply the GenTq at the HSS * Allow updating of Ind_BldPitch from int to array * Add a note about building docs * Fix global variables in Example 17a and 17b * Try numpy<2.0 * Fixed bug where TRA_LastRefSpd was set to a generator speed not the LSS speed (#381) * Check for Ind_BldPitch in original_vt --------- Co-authored-by: AbhineetGupta <abhineet.gupta@nrel.gov> Co-authored-by: Ben Clayton <55184924+BenClaytonARUP@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SS speed
Description and Purpose
Hi. I believe I have found a bug in the
RefSpeedExclusionsubroutine. WhenFA_Histis zero, currentlyVS_RefSpd_TRAis set toVS_RefSpd, which is based on the generator speed. I believe it should be set toVS_RefSpeed_LSS, which is based on the rotor speed.Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
TODO Items General:
TODO Items API Change:
Github issues addressed, if one exists
Examples/Testing, if applicable