Skip to content

Commit

Permalink
Merge pull request #17 from NREL/fix/nze_hvac
Browse files Browse the repository at this point in the history
minor sizing and control updates
  • Loading branch information
DavidGoldwasser authored Nov 12, 2020
2 parents a86c7e8 + 280ee2e commit ac6cf66
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 15 deletions.
14 changes: 8 additions & 6 deletions lib/measures/nze_hvac/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -427,18 +427,20 @@ def run(model, runner, user_arguments)
return false
end

# check that the directory name isn't too long for a sizing run; sometimes this isn't necessary
# if "#{Dir.pwd} }/SizingRun".length > 90
# runner.registerError("Directory path #{Dir.pwd}/SizingRun is greater than 90 characters and too long perform a sizing run.")
# return false
# end

# check that weather file exists for a sizing run
if !model.weatherFile.is_initialized
runner.registerError('Weather file not set. Cannot perform sizing run.')
return false
end

# ensure sizing OA method is aligned
model.getControllerMechanicalVentilations.each do |controller|
controller.setSystemOutdoorAirMethod('ZoneSum')
end

# logic to ensure variable, not cycling, pump operation for chillers
model.getChillerElectricEIRs.each { |chiller| chiller.setChillerFlowMode('LeavingSetpointModulated') }

# log the build messages and errors to a file before sizing run in case of failure
log_messages_to_file("#{Dir.pwd}/openstudio-standards.log", debug = true)

Expand Down
18 changes: 9 additions & 9 deletions lib/measures/nze_hvac/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.0</schema_version>
<name>nze_hvac</name>
<uid>f060dff2-b28d-4194-a6af-e66d88ddb33c</uid>
<version_id>83e77929-f391-407a-8aef-20994f5b7e37</version_id>
<version_modified>20200316T215557Z</version_modified>
<version_id>6d156aab-dd02-41ed-9285-82c07a45707c</version_id>
<version_modified>20201112T192500Z</version_modified>
<xml_checksum>0E5E4776</xml_checksum>
<class_name>NzeHvac</class_name>
<display_name>NZEHVAC</display_name>
Expand Down Expand Up @@ -309,6 +309,12 @@
<usage_type>license</usage_type>
<checksum>E0468DD6</checksum>
</file>
<file>
<filename>NZEHVAC_Test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>1BA0611D</checksum>
</file>
<file>
<version>
<software_program>OpenStudio</software_program>
Expand All @@ -318,13 +324,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>B06BEFD1</checksum>
</file>
<file>
<filename>NZEHVAC_Test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>1BA0611D</checksum>
<checksum>CF08F01B</checksum>
</file>
</files>
</measure>

0 comments on commit ac6cf66

Please sign in to comment.