Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify upgrade_names for run_analysis.rb #1275

Merged
merged 9 commits into from
Jul 20, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jul 19, 2024

Pull Request Description

Introduce a new optional upgrade_name argument (can be called multiple times) to run_analysis.rb.

Checklist

Not all may apply:

@joseph-robertson joseph-robertson added this to the ResStock v3.3.0 milestone Jul 19, 2024
@joseph-robertson joseph-robertson self-assigned this Jul 19, 2024
@shorowit
Copy link
Contributor

Awesome! I have definitely wanted this.

@joseph-robertson joseph-robertson marked this pull request as ready for review July 19, 2024 19:37
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked nicely for a test of mine. Just one suggestion below.

test/test_run_analysis.rb Show resolved Hide resolved
@joseph-robertson joseph-robertson merged commit d86cca2 into develop Jul 20, 2024
@joseph-robertson joseph-robertson deleted the run-analysis-specify-upgrades branch July 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants