Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest OS-HPXML #1282

Merged
merged 36 commits into from
Sep 4, 2024
Merged

Latest OS-HPXML #1282

merged 36 commits into from
Sep 4, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Aug 6, 2024

Pull Request Description

Pulls in:

Checked means that something in resstock was changed or updated as a result of pulling in.

Checklist

Not all may apply:

…c65c969

c5fa0c65c969 Merge pull request #1795 from NREL/cleanup_geothermal_loop_docs
89f400791b7d Merge pull request #1788 from NREL/mj_continued
1eec668a20fa Improve confusing docs for geothermal loops' BoreholesOrTrenches/Count. Other misc cleanup. [ci skip]
21c7a662097b More robust solution.
6d66154a2484 Latest results.
8c385d19f89d Update window ISC values -- 1/2 open for blinds means 45-degree slats (as opposed to 90-degree slats for fully open), not that the blinds cover half the window area.
653393887dd2 Latest results.
b43ae5fd5991 Some more bugfixes.
4d3a17813a95 Bugfix, update test values.
81b7658c7307 A little unrelated cleanup prompted by a @joseph-robertson comment.
bc799db4ccbf Improve handling of above-grade vs below-grade portion of foundation walls. Simplify ACCA test files. Add more tests.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: c5fa0c65c969dcce6aa6b19cfa42c2a2fa93c015
@joseph-robertson joseph-robertson added this to the ResStock v3.4.0 milestone Aug 6, 2024
@joseph-robertson joseph-robertson self-assigned this Aug 6, 2024
GitHub Action and others added 26 commits August 6, 2024 19:47
…59abdce

0c49d59abdce Merge pull request #1789 from NREL/cleanup_whole_mf_docs
29da6f71d750 Address review comments and add timeseries arguments to the workflow outputs table. Other misc cleanup.
b22907271220 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cleanup_whole_mf_docs
0f525e3ce25a Add DView example too [ci skip]
0989f2f3a281 Address feedback and a little more cleanup.
c1265042bc42 One more [ci skip]
706e35fe7ffa Minor cleanup of the docs related to modeling whole MF buildings [ci skip]

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 0c49d59abdce5939b91d740f88948dee94cc5f12
…6c00439

dbb726c00439 Merge pull request #1800 from NREL/adiabatic_windows
e05ec6d65dec Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adiabatic_windows
675ed809d270 Merge pull request #1798 from NREL/cleanup-create-windows
16b4b6566d11 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into cleanup-create-windows
e7184df91fb5 Merge pull request #1799 from NREL/ag_fndwall_bugfix
8c9afc8a7355 BuildResidentialHPXML: Clarifies that window area inputs are ignored for adiabatic walls.
9ce36094b982 Latest results.
82800f922a36 Bugfix for a foundation wall that is entirely above-grade.
062c42d9f489 Try removing (unused) model.getBuildingUnits loops.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: dbb726c00439739b08a0c7fda30e3c36a19bc888
…56e736b

1a9c556e736b Merge pull request #1802 from NREL/duct_lto_warning
5e5c3c29efa9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into duct_lto_warning
1fccf43bd728 Merge pull request #1801 from NREL/refactor_airflow_timeseries_outputs
b8a56949a8f9 Update Changelog.md [ci skip]
484692bc537b Add a warning if the sum of supply/return duct LtO values is very high.
d00eda9a5b52 Bugfix for e.g. monthly outputs.
53777ed1c294 Improve arg description
e8e3f8b95482 Creates a building-level EMS program to report timeseries airflow rates, so that we don't have to request timeseries output for each unit and sum them as part of the reporting measure. Simpler and should be faster.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 1a9c556e736b807ca4703d192f276ec54ad4982a
…65c3655

2132765c3655 Merge pull request #1806 from NREL/hpxml_4rc5
ecc0c341b271 Updates to HPXML v4.0-rc5.
f833c8c93d15 Merge pull request #1796 from NREL/bobross_tweaks
cb04cb5200d1 Latest results.
8bea78ca11db Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into bobross_tweaks
f48f26ef3357 Merge pull request #1803 from NREL/hers_sizing_methodology
ab337b39f906 Update Changelog.md [ci skip]
426260c95854 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hers_sizing_methodology
8faaceebf872 Minor cleanup of docs/changelog. [ci skip]
4a58f367ea53 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hers_sizing_methodology
0d5fe88feea3 A little code simplification/refactoring. No diffs expected.
ef7fc4110251 Latest results.
650c0ad02143 Merge pull request #1791 from NREL/battery-unavailable-periods
e29d955f1977 First try.
775eb0f9ef65 Battery charging and discharging is unavailable during an outage whether solar present or not.
df4a4f8feab4 Merge branch 'master' into battery-unavailable-periods
2c47fdd2f202 Catch warning for scheduled battery with outage period.
5d4c5b90f5b1 Revert adding battery schedules to unavailable_periods.csv.
b55992149ae5 Merge branch 'master' into battery-unavailable-periods
87545073e775 Latest results.
a6706d7ef7f4 More small tweaks to the Bob Ross test file to make it correct.
a3f40fb6879a Latest results.
91dda9a2d496 Downgrade error to a warning.
041f154fa5c9 Merge branch 'master' into battery-unavailable-periods
25a1c1dcccfc Latest results.
7e32f7cd340b Update used_by_unavailable_periods attrs.
0850d26fe990 Add battery charging and discharging to unavailable_periods.csv.
fd8f6ec7940b Demonstrate failing battery with unavailable period sample file.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 2132765c36554ad4dabccdc21c6f6372ef6b394d
…2c57a3b

dc8402c57a3b Merge pull request #1808 from NREL/constants_refactor
fb1ad7775674 Update new test.
59254fedbfbd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into constants_refactor
3cee5e65fbc0 Merge pull request #1761 from NREL/hot_water_operational_calc
4cc019ad0c10 Latest results.
0782c151162e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hot_water_operational_calc
a8583df7f2b6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into constants_refactor
abea3979c415 Merge pull request #1810 from NREL/create-apartment-fix
275392b741ae Minor code simplification.
62bf07d6eedd Oops, this OBC is needed.
b57442e058b6 Remove incorrect but unnecessary conditions from if statement in create_apartment method.
2ba8cc064a57 A few more geometry and E+ constants. Going to stop here for now.
db44cbbc2bcc Refactors constants.rb into an actual set of constants (previously methods).
37f4042038e9 Fix typo [ci skip]
77657cf04e93 Merge pull request #1784 from NREL/ruby-docs
9252cf14a4dd Minor cleanup.
1819a259cdbc Replace all @return [void] with @return [nil].
b6d57d2e4330 Revise heating_system_2_type argument description.
3932abf5285a Reference a single default schedules location in the docs.
9e3078d4bb8a A couple unrelated docs updates. [ci skip]
1974577d98de Merge branch 'master' into ruby-docs
540a630a4ec6 Merge branch 'master' into ruby-docs
7c3114b8568a Sneak in more argument description for heating_system_2_type.
0d440995dc84 Merge branch 'master' into ruby-docs
5e91e178b35b Update TODOs in location resource file and other misc places.
c9f989ede225 Latest results.
c08b2aa7791f More updates for method and name changes.
ff5405448a09 Update tasks.rb.
90451c539492 Merge branch 'master' into ruby-docs
0c20ed71cf98 Add data source columns to both schedules csv files.
33a863cd9cfd Revert refactor that apparently causes tiny decimal differences.
306ca8ed3280 Latest results.
7268fd6eaaec Merge branch 'master' into hot_water_operational_calc
88515ffecfdb Refactor schedule generator constants.
ebaae98acdbc Update TODOs for pv, battery, generator files.
9e8139e74b95 Update docs and validation test file.
60e10d7817f8 Replacements in defaults and schedules test files.
d734a86c5b20 Update schedule generator and tasks.
2adc1e69cce2 Remaining default schedule replacements.
3c53c7515cac Update schedules test file.
53c351b8fd12 First cut at moving default schedules data out of ruby.
0ffa98e7c9d8 Latest results.
2b6ca5015b70 Remaining TODOs in schedules file.
8d02569003f9 More updates to hvac and schedules.
d2f288098806 Merge branch 'master' into hot_water_operational_calc
deca9ddad333 Latest results.
a818fc591325 Merge branch 'master' into hot_water_operational_calc
b50aad977cd3 Latest results.
62c9e3469a0f Replace `reduce(:+)` with simply `sum`.
234baa32fa73 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hot_water_operational_calc
7c1b23b875bf Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hot_water_operational_calc
ca08e3af42f0 One more docs update [ci skip]
3362038060bb Update changelog [ci skip]
cff7b0d7f392 Latest results.
e2ae8533326e A little cleanup
ada8e65d0764 One more fix.
6683e91171bd Fix most CI failures.
d3f7a236fb5a For operational calculations (where NumberofResidents is provided), we now directly use equations from the FSEC paper that are a function of number of occupants.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: dc8402c57a3b458c0b119362e4a7635a0405e5a6
…dd133c2

ae750dd133c2 Merge pull request #1813 from NREL/neighbor_height
9160cc8ff2ff Fix link to neighbor docs. [ci skip]
be0d5cc4e7d3 HPXML v4.0 is final (and same as rc5). [ci skip]

git-subtree-dir: resources/hpxml-measures
git-subtree-split: ae750dd133c27749057ca3405f1f9ba088641492
…bbd9494

53efebbd9494 Merge pull request #1807 from NREL/bobross_del3
8f78e869be94 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into bobross_del3
3c5361555e09 Merge pull request #1814 from NREL/schedule_contants
3338970cb688 Converts methods in constants.rb to ruby constants.
8bd0c87dca7b Latest results.
5bdbe670e110 Merge branch 'bobross_del3' of https://github.com/NREL/OpenStudio-HPXML into bobross_del3
523d959f0e60 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into bobross_del3
80b8246f1dd3 Update a couple test files.
2ceee033764b Latest results.
c6479ac0341c Added more test cases.
7cd058b148ea Merge branch 'bobross_del3' of https://github.com/NREL/OpenStudio-HPXML into bobross_del3
d68bb4ebbf1d Some cleanup [ci skip]
1cc062a7bb72 Latest results.
1dc05d1e78ec Typo [ci skip]
82afc02a7225 Fix overhangs in 3-5 and a little cleanup.
bb4beb138741 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into bobross_del3
eb65d7b31dac Initial progress on Bob Ross sensitivity runs. Added optional InfiltrationShieldingClass input.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 53efebbd9494c3f59199f78c6dd632c84cc71379
joseph-robertson and others added 7 commits August 28, 2024 14:41
…15fe48a

c2cec15fe48a Merge pull request #1749 from NREL/slab_wing_insulation
fec6dc8d7299 Latest results.
535b72801bd4 Misc bugfixes and cleanup.
3944b04da96c Merge branch 'master' into slab_wing_insulation
c5ef7c66cae6 Latest results.
368f10612854 Debug attempt to address nil comparison and Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
a9e37ff37b70 Removing redundant statement in line 4334 of hvac_sizing.rb.
2ec49599cbd0 Adding further conditions to utilizing exterior horizontal insulation in ACCA Manual J calculations for HVAC sizing, and adjusting the conditions to independently account for insulations encountered in the soil path.
383a9ff6e55f Adding exterior horizontal insulation R-value to the total soil path R-value for HVAC sizing calculations.
1c6a574ac061 Merge branch 'slab_wing_insulation' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
738e135a3c72 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
b05daf0da0f4 Merge branch 'master' into slab_wing_insulation
4be66fdaf6c0 Test commit.
584eff2d03df Changelog updated.
3d1c454e8737 Latest results.
9de6227d3c7c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
29f81af2be94 Debug commit: object name fixed for test_validation.rb line 1012
32574cc549ea _hpxml_bldg changed to hpxml_bldg in test_validation.rb line 1011
55b98ee665cc Temporary commit.
035413a8d203 Temporary commit.
3f2f20804a53 Merge branch 'master' into slab_wing_insulation
635a0fb024bf Debug commit.
a022f4bfb5a5 Temporary commit
9d938da36dde Latest results.
ce9f2db44256 Revert additional HPXML changes.
d2f37f369be9 Remove empty elements from sample HPXML files and misc cleanup.
8b6aec152d3e Change measure arguments to be optional.
faa903a0a2ef Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
c013b49cc107 Fix tests and docs.
bbb825dd7bd0 Merge branch 'master' into slab_wing_insulation
0044ff9a4a73 Temporary commit.
dce6d0fec1bc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
8d61af234ab5 Documentation comment added per review comment.
2b7c80f3815d Comments added with TODO identifying added parameters.
b91866fa685d Merge branch 'master' into slab_wing_insulation
321669751114 Merge branch 'slab_wing_insulation' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
4635e7e30272 Partially addressed review comments. test_slabs modification remaining.
7d23178aa6a2 Update BuildResidentialHPXML/measure.rb
4cbb7b05e61f Temporary commit.
c0b9d48656db Fix bad merge conflict resolution.
39a00a9a1113 Debug commit.
6071e6de0bc4 Update measure.xml
ee3ae7f35479 Merge branch 'master' into slab_wing_insulation
8d014a6cc1eb Documentation updated.
a757bfe90873 Latest results.
edf286cfa12c Fix docs error.
9cbf3b1780f3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into slab_wing_insulation
12a824d1c2c8 Fix CI failures.
f351532fdc4d Debug commit.
abd82e106b37 Merge branch 'master' into slab_wing_insulation
68151b4cf7b8 Merged latest master.
e0dc8f8d1d61 Debug commit.
8a227a06f334 Updates.
1f6118eb143b Debug commit.
1a82461cf24f Documentation image update. Debug ongoing.
d79922c8aaf6 debug commit
5f5353397fe9 temporary commit
8053f3b9c0e3 Merge branch 'master' into slab_wing_insulation
699ef040eee5 temporary commit
3ffbadbfc98f Schema update

git-subtree-dir: resources/hpxml-measures
git-subtree-split: c2cec15fe48a61ed2d78a504bb758f4028d2833f
@joseph-robertson joseph-robertson marked this pull request as ready for review September 4, 2024 15:19
@joseph-robertson joseph-robertson merged commit 6e6c793 into develop Sep 4, 2024
@joseph-robertson joseph-robertson deleted the latest-os-hpxml branch September 4, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant