Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing facility specification #129

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix missing facility specification #129

merged 3 commits into from
Jan 10, 2025

Conversation

JunAishima
Copy link
Contributor

@JunAishima
fix missing facility specification
c18f26a 
 * default of nsls2 results in PASS API exception:
   httpx.HTTPStatusError: Client error '400 Bad Request' for url 'https://passservices.bnl.gov/....../NSLS-II/300047/null'
@JunAishima
make facility name kwarg, use facility name
d94f1e9 
 * use facility_name instead of cycle.facility because this is of
   type `FacilityName`
@JunAishima
fix Cycle.find_one() to include facility in query
8b068ce 
 * ensure that the appropriate cycle is found, because
   the cycle name may be the same between multiple facilities
@JunAishima
Copy link
Contributor Author

also found that the original issue was due to mismatch of a cycle's PASS ID and the facility name associated with that cycle. thus, fixed queries where Cycle.find_one() was not specifying facility, resulting in the NSLS2 one always being retrieved

@stuartcampbell stuartcampbell merged commit e12eade into NSLS2:main Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartcampbell stuartcampbell stuartcampbell approved these changes

@nmaytan nmaytan nmaytan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunAishima @stuartcampbell @nmaytan