-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Sonar Job for code analysis #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments for some minor changes. LGTM.
|
||
const createProjectIfNotExists = async (repo: string) => { | ||
try { | ||
const sonarUri = process.env.SONAR_URI; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is sonarUri
a fixed string? If it is just a fixed string value, we can put it in endpoints.ts
instead of as an environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During dev, I first test it out on localhost, before testing it out on staging so I do change the sonarUri. On staging and eventually prod itll be localhost:9000
|
Description
Created job that:
Changes
Screenshots (if applicable)
Additional Notes
Include any additional comments or context.
Resolves #198