Feature/tas 8 helper methods for authentication #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d10f696.
…testing Set up Testing
gnimnix
requested changes
Feb 8, 2024
Comment on lines
+1
to
+3
| const BASE_URL = 'https://example.com/auth'; | ||
| const LOGIN_URL = `${BASE_URL}/login`; | ||
| const LOGOUT_URL = `${BASE_URL}/logout`; |
There was a problem hiding this comment.
use resolveURL function from @/src/api/fetch
| throw new Error('Failed to sign in'); | ||
| } | ||
|
|
||
| return response.json(); |
There was a problem hiding this comment.
should return response object and not json
| // Clear cookies on the client side | ||
| document.cookie.split(';').forEach(cookie => { | ||
| document.cookie = cookie.replace(/^ +/, '').replace(/=.*/, '=;expires=' + new Date().toUTCString() + ';path=/'); | ||
| }); |
There was a problem hiding this comment.
should return response too, in case sign out failed and errors can be handled
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, |
There was a problem hiding this comment.
need to set credentials to include to save csrf token
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Create authentication.ts file with helper methods for user sign in and sign out.
Related Issues
Checklist
Please review and check the following before submitting your pull request:
Screenshots (if applicable)
Desktop
Mobile
Additional Information
Reviewer Notes