Feature/tas 13 layout #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Cleaning - 1
add trial code for layout container
|
@markgcera , next time can do a merge from |
…omponents-and-layouts' into feature/TAS-13-Layout # Conflicts: # src/routes/App.tsx
gnimnix
approved these changes
May 22, 2024
gnimnix
merged commit 30f32ce
into
epic/DEV-4-shared-components-and-layouts
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Hi Xinming, this PR is coming from a branch which branched off from main, which is why there are so many changed files. The only file I added is the 'layout.tsx' file which contains commented out code for the layout container, with comments on how to use the container.
Related Issues
[Reference any related issues that this pull request addresses or resolves.]
Checklist
Please review and check the following before submitting your pull request:
Screenshots (if applicable)
[Include any relevant screenshots or GIFs to visually demonstrate the changes.]
Desktop
Mobile
Additional Information
[Include any additional information that might be helpful for reviewers or maintainers.]
Reviewer Notes
[Optional: Include specific instructions or notes for reviewers, if necessary.]