Refactored controllers to require <tag>Service #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd-rite
reviewed
Oct 12, 2023
api/source/controllers/Asset.js
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const writer = require('../utils/writer'); | |||
| const config = require('../utils/config') | |||
| const Asset = require(`../service/${config.database.type}/AssetService`); | |||
| const AssetService = require(`../service/${config.database.type}/AssetService`); | |||
| const Collection = require(`../service/${config.database.type}/CollectionService`); | |||
There was a problem hiding this comment.
collection -> CollectionService
cd-rite
reviewed
Oct 12, 2023
api/source/controllers/Collection.js
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const writer = require('../utils/writer') | |||
| const config = require('../utils/config') | |||
| const CollectionSvc = require(`../service/${config.database.type}/CollectionService`) | |||
| const CollectionService = require(`../service/${config.database.type}/CollectionService`) | |||
| const AssetSvc = require(`../service/${config.database.type}/AssetService`) | |||
There was a problem hiding this comment.
AssetSvc -> AssetService
StigSvc -> STIGService
cd-rite
reviewed
Oct 12, 2023
api/source/controllers/User.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const config = require('../utils/config') | |||
| const User = require(`../service/${config.database.type}/UserService`) | |||
| const UserService = require(`../service/${config.database.type}/UserService`) | |||
| const Asset = require(`../service/${config.database.type}/AssetService`) | |||
There was a problem hiding this comment.
Asset -> AssetService
Collection -> CollectionService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1096
All controllers have been improved for clarity/readability when calling their service.
FROM:
const Asset = require(../service/${config.database.type}/AssetService);
TO:
const AssetService = require(../service/${config.database.type}/AssetService);
By renaming the variable to AssetService, it becomes evident that this is sourced from our service.